Mop up assorted set-but-not-used warnings in the back branches.
This includes back-patching relevant fixes from commit
152c9f7b8
the rest of the way, but there are also several cases that did not
appear in HEAD. Some of those we'd fixed in a retail way but not
back-patched, and others I think just got rewritten out of existence
during nearby refactoring.
While here, also back-patch
b1980f6d0 (PL/Tcl: Fix compiler warnings
with Tcl 8.6) into 9.2, so that that branch compiles warning-free
with modern Tcl.
Per project policy, this is a candidate for back-patching into
out-of-support branches: it suppresses annoying compiler warnings
but changes no behavior. Hence, back-patch all the way to 9.2.
Discussion: https://postgr.es/m/514615.
1663615243@sss.pgh.pa.us
{
unsigned int crc = ~((unsigned int) 0);
char *p;
- int len,
- nr;
+ int nr;
- len = 0;
nr = size;
- for (len += nr, p = buf; nr--; ++p)
+ for (p = buf; nr--; ++p)
_CRC32_(crc, *p);
return ~crc;
}
{
unsigned int crc = ~((unsigned int) 0);
char *p;
- int len,
- nr;
+ int nr;
- len = 0;
nr = size;
- for (len += nr, p = buf; nr--; ++p)
+ for (p = buf; nr--; ++p)
_CRC32_(crc, TOLOWER((unsigned int) *p));
return ~crc;
}
XLogRecPtr NewPageEndPtr = InvalidXLogRecPtr;
XLogRecPtr NewPageBeginPtr;
XLogPageHeader NewPage;
+#ifdef WAL_DEBUG
int npages = 0;
+#endif
LWLockAcquire(WALBufMappingLock, LW_EXCLUSIVE);
XLogCtl->InitializedUpTo = NewPageEndPtr;
+#ifdef WAL_DEBUG
npages++;
+#endif
}
LWLockRelease(WALBufMappingLock);
RowExpr *rowexpr;
List *fields = NIL;
List *colnames = NIL;
- AttrNumber attnum;
ListCell *lv;
ListCell *ln;
- attnum = 0;
Assert(list_length(rte->joinaliasvars) == list_length(rte->eref->colnames));
forboth(lv, rte->joinaliasvars, ln, rte->eref->colnames)
{
newvar = (Node *) lfirst(lv);
- attnum++;
/* Ignore dropped columns */
if (newvar == NULL)
continue;
stmtblock: stmtmulti
{
pg_yyget_extra(yyscanner)->parsetree = $1;
+ (void) yynerrs; /* suppress compiler warning */
}
;
{
ArrayAnalyzeExtraData *extra_data;
int num_mcelem;
- int null_cnt = 0;
int null_elem_cnt = 0;
int analyzed_rows = 0;
value = fetchfunc(stats, array_no, &isnull);
if (isnull)
{
- /* array is null, just count that */
- null_cnt++;
+ /* ignore arrays that are null overall */
continue;
}
* to search for occurrences of fldsep.
*/
TextPositionState state;
- int fldnum;
int start_posn;
int end_posn;
int chunk_len;
/* start_ptr points to the start_posn'th character of inputstring */
start_ptr = VARDATA_ANY(inputstring);
- for (fldnum = 1;; fldnum++) /* field number is 1 based */
+ for (;;)
{
CHECK_FOR_INTERRUPTS();