Temporarily skip recovery deadlock test in back branches.
authorAndres Freund <[email protected]>
Fri, 6 May 2022 16:01:08 +0000 (09:01 -0700)
committerAndres Freund <[email protected]>
Fri, 6 May 2022 16:07:44 +0000 (09:07 -0700)
The recovery deadlock test has a timing issue that was fixed in 5136967f1eb in
HEAD. Unfortunately the same fix doesn't quite work in the back branches: 1)
adjust_conf() doesn't exist, which is easy enough to work around 2) a restart
cleares the recovery conflict stats < 15.

These issues can be worked around, but given the upcoming set of minor
releases, skip the problematic test for now. The buildfarm doesn't show
failures in other parts of 031_recovery_conflict.pl.

Discussion: https://postgr.es/m/20220506155827[email protected]
Backpatch: 10-14

src/test/recovery/t/031_recovery_conflict.pl

index aa36582d1100973c30af16367ae7dfe67d45ebc1..0525dac8bcb199940ce645162d68561e0f22fc74 100644 (file)
@@ -228,6 +228,10 @@ check_conflict_stat("lock");
 
 
 ## RECOVERY CONFLICT 5: Deadlock
+SKIP:
+{
+   skip "disabled until after minor releases, due to instability";
+
 $sect = "startup deadlock";
 $expected_conflicts++;
 
@@ -286,6 +290,7 @@ check_conflict_stat("deadlock");
 
 # clean up for next tests
 $node_primary->safe_psql($test_db, qq[ROLLBACK PREPARED 'lock';]);
+}
 
 
 # Check that expected number of conflicts show in pg_stat_database. Needs to