Revert "Improve pg_basebackup long file name test Windows robustness"
authorAndrew Dunstan <[email protected]>
Mon, 3 Jul 2023 14:53:16 +0000 (10:53 -0400)
committerAndrew Dunstan <[email protected]>
Mon, 3 Jul 2023 14:58:04 +0000 (10:58 -0400)
Version 13 and older are missing the required infrastructure.

src/bin/pg_basebackup/t/010_pg_basebackup.pl

index 4311f6547a73709c6b1b4aab3f4c7879b3399de0..ac1ac79470385012ecae8e38ff9d1152dd36ae0d 100644 (file)
@@ -200,12 +200,8 @@ $node->command_fails(
    '-T with invalid format fails');
 
 # Tar format doesn't support filenames longer than 100 bytes.
-# Create the test file via a short name directory so it doesn't blow the
-# Windows path limit.
-my $lftmp = TestLib::tempdir_short;
-dir_symlink "$pgdata", "$lftmp/pgdata";
 my $superlongname = "superlongname_" . ("x" x 100);
-my $superlongpath = "$lftmp/pgdata/$superlongname";
+my $superlongpath = "$pgdata/$superlongname";
 
 open my $file, '>', "$superlongpath"
   or die "unable to create file $superlongpath";
@@ -213,7 +209,7 @@ close $file;
 $node->command_fails(
    [ 'pg_basebackup', '-D', "$tempdir/tarbackup_l1", '-Ft' ],
    'pg_basebackup tar with long name fails');
-unlink "$superlongpath";
+unlink "$pgdata/$superlongname";
 
 # The following tests test symlinks. Windows doesn't have symlinks, so
 # skip on Windows.