Fix MVCC bug with prepared xact with subxacts on standby

We did not recover the subtransaction IDs of prepared transactions
when starting a hot standby from a shutdown checkpoint. As a result,
such subtransactions were considered as aborted, rather than
in-progress. That would lead to hint bits being set incorrectly, and
the subtransactions suddenly becoming visible to old snapshots when
the prepared transaction was committed.

To fix, update pg_subtrans with prepared transactions's subxids when
starting hot standby from a shutdown checkpoint. The snapshots taken
from that state need to be marked as "suboverflowed", so that we also
check the pg_subtrans.

Backport to all supported versions.

Discussion: https://www.postgresql.org/message-id/6b852e98-2d49-4ca1-9e95-db419a2696e0@iki.fi

diff --git a/src/backend/access/transam/twophase.c b/src/backend/access/transam/twophase.c
index db68b1444319d76047959a38c196f370183a4578..29af9d208ee5b82b0616eb7ec5b7a0d59310820e 100644 (file)
--- a/src/backend/access/transam/twophase.c
+++ b/src/backend/access/transam/twophase.c
@@ -1986,9 +1986,8 @@ PrescanPreparedTransactions(TransactionId **xids_p, int *nxids_p)
  * This is never called at the end of recovery - we use
  * RecoverPreparedTransactions() at that point.
  *
- * The lack of calls to SubTransSetParent() calls here is by design;
- * those calls are made by RecoverPreparedTransactions() at the end of recovery
- * for those xacts that need this.
+ * This updates pg_subtrans, so that any subtransactions will be correctly
+ * seen as in-progress in snapshots taken during recovery.
  */
 void
 StandbyRecoverPreparedTransactions(void)
@@ -2008,7 +2007,7 @@ StandbyRecoverPreparedTransactions(void)
 
        buf = ProcessTwoPhaseBuffer(xid,
                                    gxact->prepare_start_lsn,
-                                   gxact->ondisk, false, false);
+                                   gxact->ondisk, true, false);
        if (buf != NULL)
            pfree(buf);
    }

diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c
index fd5a9f66fa1c59b9519a7f08fc65bde583487b45..7654ad76de187a9ff24b63f43eefd98ca83a1f8f 100644 (file)
--- a/src/backend/access/transam/xlog.c
+++ b/src/backend/access/transam/xlog.c
@@ -7283,6 +7283,9 @@ StartupXLOG(void)
                RunningTransactionsData running;
                TransactionId latestCompletedXid;
 
+               /* Update pg_subtrans entries for any prepared transactions */
+               StandbyRecoverPreparedTransactions();
+
                /*
                 * Construct a RunningTransactions snapshot representing a
                 * shut down server, with only prepared transactions still
@@ -7291,7 +7294,7 @@ StartupXLOG(void)
                 */
                running.xcnt = nxids;
                running.subxcnt = 0;
-               running.subxid_overflow = false;
+               running.subxid_status = SUBXIDS_IN_SUBTRANS;
                running.nextXid = XidFromFullTransactionId(checkPoint.nextXid);
                running.oldestRunningXid = oldestActiveXID;
                latestCompletedXid = XidFromFullTransactionId(checkPoint.nextXid);
@@ -7301,8 +7304,6 @@ StartupXLOG(void)
                running.xids = xids;
 
                ProcArrayApplyRecoveryInfo(&running);
-
-               StandbyRecoverPreparedTransactions();
            }
        }
 
@@ -10424,6 +10425,9 @@ xlog_redo(XLogReaderState *record)
 
            oldestActiveXID = PrescanPreparedTransactions(&xids, &nxids);
 
+           /* Update pg_subtrans entries for any prepared transactions */
+           StandbyRecoverPreparedTransactions();
+
            /*
             * Construct a RunningTransactions snapshot representing a shut
             * down server, with only prepared transactions still alive. We're
@@ -10432,7 +10436,7 @@ xlog_redo(XLogReaderState *record)
             */
            running.xcnt = nxids;
            running.subxcnt = 0;
-           running.subxid_overflow = false;
+           running.subxid_status = SUBXIDS_IN_SUBTRANS;
            running.nextXid = XidFromFullTransactionId(checkPoint.nextXid);
            running.oldestRunningXid = oldestActiveXID;
            latestCompletedXid = XidFromFullTransactionId(checkPoint.nextXid);
@@ -10442,8 +10446,6 @@ xlog_redo(XLogReaderState *record)
            running.xids = xids;
 
            ProcArrayApplyRecoveryInfo(&running);
-
-           StandbyRecoverPreparedTransactions();
        }
 
        /* ControlFile->checkPointCopy always tracks the latest ckpt XID */

diff --git a/src/backend/storage/ipc/procarray.c b/src/backend/storage/ipc/procarray.c
index 4247d7feae6f70369c5f111550d73c84f315b29d..76093e6c162c7afdfd11d3748c2f385c723a77d0 100644 (file)
--- a/src/backend/storage/ipc/procarray.c
+++ b/src/backend/storage/ipc/procarray.c
@@ -1108,7 +1108,7 @@ ProcArrayApplyRecoveryInfo(RunningTransactions running)
         * If the snapshot isn't overflowed or if its empty we can reset our
         * pending state and use this snapshot instead.
         */
-       if (!running->subxid_overflow || running->xcnt == 0)
+       if (running->subxid_status != SUBXIDS_MISSING || running->xcnt == 0)
        {
            /*
             * If we have already collected known assigned xids, we need to
@@ -1260,7 +1260,7 @@ ProcArrayApplyRecoveryInfo(RunningTransactions running)
     * missing, so conservatively assume the last one is latestObservedXid.
     * ----------
     */
-   if (running->subxid_overflow)
+   if (running->subxid_status == SUBXIDS_MISSING)
    {
        standbyState = STANDBY_SNAPSHOT_PENDING;
 
@@ -1272,6 +1272,18 @@ ProcArrayApplyRecoveryInfo(RunningTransactions running)
        standbyState = STANDBY_SNAPSHOT_READY;
 
        standbySnapshotPendingXmin = InvalidTransactionId;
+
+       /*
+        * If the 'xids' array didn't include all subtransactions, we have to
+        * mark any snapshots taken as overflowed.
+        */
+       if (running->subxid_status == SUBXIDS_IN_SUBTRANS)
+           procArray->lastOverflowedXid = latestObservedXid;
+       else
+       {
+           Assert(running->subxid_status == SUBXIDS_IN_ARRAY);
+           procArray->lastOverflowedXid = InvalidTransactionId;
+       }
    }
 
    /*
@@ -2898,7 +2910,7 @@ GetRunningTransactionData(void)
 
    CurrentRunningXacts->xcnt = count - subcount;
    CurrentRunningXacts->subxcnt = subcount;
-   CurrentRunningXacts->subxid_overflow = suboverflowed;
+   CurrentRunningXacts->subxid_status = suboverflowed ? SUBXIDS_IN_SUBTRANS : SUBXIDS_IN_ARRAY;
    CurrentRunningXacts->nextXid = XidFromFullTransactionId(ShmemVariableCache->nextXid);
    CurrentRunningXacts->oldestRunningXid = oldestRunningXid;
    CurrentRunningXacts->latestCompletedXid = latestCompletedXid;

diff --git a/src/backend/storage/ipc/standby.c b/src/backend/storage/ipc/standby.c
index 687ce03767dcefc921f5f0f9788481ea73744c3b..49cccad9bf6d4b015d8853566d8fa19c4b28c9a9 100644 (file)
--- a/src/backend/storage/ipc/standby.c
+++ b/src/backend/storage/ipc/standby.c
@@ -1130,7 +1130,7 @@ standby_redo(XLogReaderState *record)
 
        running.xcnt = xlrec->xcnt;
        running.subxcnt = xlrec->subxcnt;
-       running.subxid_overflow = xlrec->subxid_overflow;
+       running.subxid_status = xlrec->subxid_overflow ? SUBXIDS_MISSING : SUBXIDS_IN_ARRAY;
        running.nextXid = xlrec->nextXid;
        running.latestCompletedXid = xlrec->latestCompletedXid;
        running.oldestRunningXid = xlrec->oldestRunningXid;
@@ -1286,7 +1286,7 @@ LogCurrentRunningXacts(RunningTransactions CurrRunningXacts)
 
    xlrec.xcnt = CurrRunningXacts->xcnt;
    xlrec.subxcnt = CurrRunningXacts->subxcnt;
-   xlrec.subxid_overflow = CurrRunningXacts->subxid_overflow;
+   xlrec.subxid_overflow = (CurrRunningXacts->subxid_status != SUBXIDS_IN_ARRAY);
    xlrec.nextXid = CurrRunningXacts->nextXid;
    xlrec.oldestRunningXid = CurrRunningXacts->oldestRunningXid;
    xlrec.latestCompletedXid = CurrRunningXacts->latestCompletedXid;
@@ -1303,7 +1303,7 @@ LogCurrentRunningXacts(RunningTransactions CurrRunningXacts)
 
    recptr = XLogInsert(RM_STANDBY_ID, XLOG_RUNNING_XACTS);
 
-   if (CurrRunningXacts->subxid_overflow)
+   if (xlrec.subxid_overflow)
        elog(trace_recovery(DEBUG2),
             "snapshot of %u running transactions overflowed (lsn %X/%X oldest xid %u latest complete %u next xid %u)",
             CurrRunningXacts->xcnt,

diff --git a/src/include/storage/standby.h b/src/include/storage/standby.h
index 38fd85a4316c1db8d4a4c6ebcdcc643495206a14..92fc13e25a33c11fcdcbeecb1303ca2e61ee463f 100644 (file)
--- a/src/include/storage/standby.h
+++ b/src/include/storage/standby.h
@@ -74,11 +74,19 @@ extern void StandbyReleaseOldLocks(TransactionId oldxid);
  * almost immediately see the data we need to begin executing queries.
  */
 
+typedef enum
+{
+   SUBXIDS_IN_ARRAY,           /* xids array includes all running subxids */
+   SUBXIDS_MISSING,            /* snapshot overflowed, subxids are missing */
+   SUBXIDS_IN_SUBTRANS,        /* subxids are not included in 'xids', but
+                                * pg_subtrans is fully up-to-date */
+} subxids_array_status;
+
 typedef struct RunningTransactionsData
 {
    int         xcnt;           /* # of xact ids in xids[] */
    int         subxcnt;        /* # of subxact ids in xids[] */
-   bool        subxid_overflow;    /* snapshot overflowed, subxids missing */
+   subxids_array_status subxid_status;
    TransactionId nextXid;      /* xid from ShmemVariableCache->nextXid */
    TransactionId oldestRunningXid; /* *not* oldestXmin */
    TransactionId latestCompletedXid;   /* so we can set xmax */

diff --git a/src/test/recovery/t/009_twophase.pl b/src/test/recovery/t/009_twophase.pl
index 900d181788c9ae644a3883f9f3bf7c36fce4dced..b9d96453167bbb03200ff31ae73a5c81da47829e 100644 (file)
--- a/src/test/recovery/t/009_twophase.pl
+++ b/src/test/recovery/t/009_twophase.pl
@@ -7,7 +7,7 @@ use warnings;
 
 use PostgresNode;
 use TestLib;
-use Test::More tests => 24;
+use Test::More tests => 27;
 
 my $psql_out = '';
 my $psql_rc  = '';
@@ -308,6 +308,52 @@ $cur_standby->start;
 
 $cur_primary->psql('postgres', "COMMIT PREPARED 'xact_009_12'");
 
+###############################################################################
+# Check visibility of prepared transactions in standby after a restart while
+# primary is down.
+###############################################################################
+
+$cur_primary->psql(
+   'postgres', "
+   CREATE TABLE t_009_tbl_standby_mvcc (id int, msg text);
+   BEGIN;
+   INSERT INTO t_009_tbl_standby_mvcc VALUES (1, 'issued to ${cur_primary_name}');
+   SAVEPOINT s1;
+   INSERT INTO t_009_tbl_standby_mvcc VALUES (2, 'issued to ${cur_primary_name}');
+   PREPARE TRANSACTION 'xact_009_standby_mvcc';
+   ");
+$cur_primary->stop;
+$cur_standby->restart;
+
+# Acquire a snapshot in standby, before we commit the prepared transaction
+my $standby_session = $cur_standby->background_psql('postgres', on_error_die => 1);
+$standby_session->query_safe("BEGIN ISOLATION LEVEL REPEATABLE READ");
+$psql_out = $standby_session->query_safe(
+   "SELECT count(*) FROM t_009_tbl_standby_mvcc");
+is($psql_out, '0',
+   "Prepared transaction not visible in standby before commit");
+
+# Commit the transaction in primary
+$cur_primary->start;
+$cur_primary->psql('postgres', "
+SET synchronous_commit='remote_apply'; -- To ensure the standby is caught up
+COMMIT PREPARED 'xact_009_standby_mvcc';
+");
+
+# Still not visible to the old snapshot
+$psql_out = $standby_session->query_safe(
+   "SELECT count(*) FROM t_009_tbl_standby_mvcc");
+is($psql_out, '0',
+   "Committed prepared transaction not visible to old snapshot in standby");
+
+# Is visible to a new snapshot
+$standby_session->query_safe("COMMIT");
+$psql_out = $standby_session->query_safe(
+   "SELECT count(*) FROM t_009_tbl_standby_mvcc");
+is($psql_out, '2',
+   "Committed prepared transaction is visible to new snapshot in standby");
+$standby_session->quit;
+
 ###############################################################################
 # Check for a lock conflict between prepared transaction with DDL inside and
 # replay of XLOG_STANDBY_LOCK wal record.

diff --git a/src/tools/pgindent/typedefs.list b/src/tools/pgindent/typedefs.list
index fb59bd3be730cc21970298b08144dac12622e9f4..6266bd46f5f8b95ae6a5bb04c0c52462ef440d9b 100644 (file)
--- a/src/tools/pgindent/typedefs.list
+++ b/src/tools/pgindent/typedefs.list
@@ -3558,6 +3558,7 @@ string
 substitute_actual_parameters_context
 substitute_actual_srf_parameters_context
 substitute_phv_relids_context
+subxids_array_status
 svtype
 symbol
 tablespaceinfo