Fix race condition in committing a serializable transaction

The finished transaction list can contain XIDs that are older than the
serializable global xmin. It's a short-lived state;
ClearOldPredicateLocks() removes any such transactions from the list,
and it's called whenever the global xmin advances. But if another
backend calls SummarizeOldestCommittedSxact() in that window, it will
call SerialAdd() on an XID that's older than the global xmin, or if
there are no more transactions running, when global xmin is
invalid. That trips the assertion in SerialAdd().

Fixes bug #18658 reported by Andrew Bille. Thanks to Alexander Lakhin
for analysis. Backpatch to all versions.

Discussion: https://www.postgresql.org/message-id/18658-7dab125ec688c70b%40postgresql.org

diff --git a/src/backend/storage/lmgr/predicate.c b/src/backend/storage/lmgr/predicate.c
index 10708b9286d37d798553f62af6804aa142a50691..2288f51ea9ce9be4917d141ffa585d71bf7145a7 100644 (file)
--- a/src/backend/storage/lmgr/predicate.c
+++ b/src/backend/storage/lmgr/predicate.c
@@ -923,12 +923,17 @@ OldSerXidAdd(TransactionId xid, SerCommitSeqNo minConflictCommitSeqNo)
    LWLockAcquire(OldSerXidLock, LW_EXCLUSIVE);
 
    /*
-    * If no serializable transactions are active, there shouldn't be anything
-    * to push out to the SLRU.  Hitting this assert would mean there's
-    * something wrong with the earlier cleanup logic.
+    * If 'xid' is older than the global xmin (== tailXid), there's no need to
+    * store it, after all. This can happen if the oldest transaction holding
+    * back the global xmin just finished, making 'xid' uninteresting, but
+    * ClearOldPredicateLocks() has not yet run.
     */
    tailXid = oldSerXidControl->tailXid;
-   Assert(TransactionIdIsValid(tailXid));
+   if (!TransactionIdIsValid(tailXid) || TransactionIdPrecedes(xid, tailXid))
+   {
+       LWLockRelease(OldSerXidLock);
+       return;
+   }
 
    /*
     * If the SLRU is currently unused, zero out the whole active region from