From: Andres Freund Date: Thu, 25 Apr 2024 14:51:33 +0000 (-0700) Subject: Avoid unnecessary "touch meson.build" in vpath builds X-Git-Tag: REL_16_3~18 X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=2209c70c652e57314961a25725266821721415b8;p=postgresql.git Avoid unnecessary "touch meson.build" in vpath builds In e6927270cd1 I added a 'touch meson.build' to configure.ac, to ensure conflicts between in-tree configure based builds and meson builds are automatically detected. Unfortunately I omitted spaces around the condition restricting this to in-tree builds, leading to touch meson.build to also be executed in vpath builds. While the only consequence of this buglet is an unnecessary empty file in build directories, it seems worth backpatching. Reported-by: Christoph Berg Discussion: https://postgr.es/m/20240417230002.mb2gv3hyetyn67gk@awork3.anarazel.de Backpatch: 16-, where the meson based build was added --- diff --git a/configure b/configure index 375a8b7dbc4..0d29e35c20f 100755 --- a/configure +++ b/configure @@ -20827,6 +20827,6 @@ fi # Ensure that any meson build directories would reconfigure and see that # there's a conflicting in-tree build and can error out. -if test "$vpath_build"="no"; then +if test "$vpath_build" = "no"; then touch meson.build fi diff --git a/configure.ac b/configure.ac index aed940410c3..ee4e3e2b664 100644 --- a/configure.ac +++ b/configure.ac @@ -2500,6 +2500,6 @@ AC_OUTPUT # Ensure that any meson build directories would reconfigure and see that # there's a conflicting in-tree build and can error out. -if test "$vpath_build"="no"; then +if test "$vpath_build" = "no"; then touch meson.build fi