From: Daniel Gustafsson <dgustafsson@postgresql.org>
Date: Tue, 19 Dec 2023 13:13:50 +0000 (+0100)
Subject: doc: Fix syntax in ALTER FOREIGN DATA WRAPPER example
X-Git-Tag: REL_13_14~44
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=57d55e2cd81a12926467030bed98271a72155318;p=postgresql.git

doc: Fix syntax in ALTER FOREIGN DATA WRAPPER example

The example for dropping an option was incorrectly quoting the
option key thus making it a value turning the command into an
unqualified ADD operation. The result of dropping became adding
a new key/value pair instead:

 d=# alter foreign data wrapper f options (drop 'b');
 ALTER FOREIGN DATA WRAPPER
 d=# select fdwoptions from pg_foreign_data_wrapper where fdwname='f';
  fdwoptions
 ------------
  {drop=b}
 (1 row)

This has been incorrect for a long time so backpatch to all
supported branches.

Author: Tim <tim.needham2@gmail.com>
Discussion: https://postgr.es/m/170292280173.1876505.5204623074024041738@wrigleys.postgresql.org
---

diff --git a/doc/src/sgml/ref/alter_foreign_data_wrapper.sgml b/doc/src/sgml/ref/alter_foreign_data_wrapper.sgml
index 14f3d616e71..3a517480449 100644
--- a/doc/src/sgml/ref/alter_foreign_data_wrapper.sgml
+++ b/doc/src/sgml/ref/alter_foreign_data_wrapper.sgml
@@ -153,7 +153,7 @@ ALTER FOREIGN DATA WRAPPER <replaceable class="parameter">name</replaceable> REN
    Change a foreign-data wrapper <literal>dbi</literal>, add
    option <literal>foo</literal>, drop <literal>bar</literal>:
 <programlisting>
-ALTER FOREIGN DATA WRAPPER dbi OPTIONS (ADD foo '1', DROP 'bar');
+ALTER FOREIGN DATA WRAPPER dbi OPTIONS (ADD foo '1', DROP bar);
 </programlisting>
   </para>