From: Noah Misch <noah@leadboat.com>
Date: Tue, 14 Apr 2020 01:47:28 +0000 (-0700)
Subject: Add a wait_for_catchup() before immediate stop of a test master.
X-Git-Tag: REL_10_13~29
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=ab7699e86c161960c44b51d1a7e6d32784cf5299;p=postgresql.git

Add a wait_for_catchup() before immediate stop of a test 

Per buildfarm member hoverfly, a slow walsender could make the test
fail.  Back-patch to v10, where the test was introduced.

Discussion: https://postgr.es/m/20200414013849.GA886648@rfd.leadboat.com
---

diff --git a/src/test/recovery/t/010_logical_decoding_timelines.pl b/src/test/recovery/t/010_logical_decoding_timelines.pl
index 1f3d4f72f74..7114aa7d967 100644
--- a/src/test/recovery/t/010_logical_decoding_timelines.pl
+++ b/src/test/recovery/t/010_logical_decoding_timelines.pl
@@ -130,6 +130,7 @@ cmp_ok(
 	'xmin on physical slot must not be lower than catalog_xmin');
 
 $node_master->safe_psql('postgres', 'CHECKPOINT');
+$node_master->wait_for_catchup($node_replica, 'write');
 
 # Boom, crash
 $node_master->stop('immediate');