From: Tom Lane <tgl@sss.pgh.pa.us>
Date: Fri, 13 Sep 2024 20:16:47 +0000 (-0400)
Subject: Allow _h_indexbuild() to be interrupted.
X-Git-Tag: REL_13_17~84
X-Git-Url: http://git.postgresql.org/gitweb/?a=commitdiff_plain;h=b27215dbb42b6376515e1ab1ff06e0ad9ab13450;p=postgresql.git

Allow _h_indexbuild() to be interrupted.

When we are building a hash index that is large enough to need
pre-sorting (larger than either maintenance_work_mem or NBuffers),
the initial sorting phase is interruptible, but the insertion
phase wasn't.  Add the missing CHECK_FOR_INTERRUPTS().

Per bug #18616 from Alexander Lakhin.  Back-patch to all
supported branches.

Pavel Borisov

Discussion: https://postgr.es/m/18616-acbb9e5caf41e964@postgresql.org
---

diff --git a/src/backend/access/hash/hashsort.c b/src/backend/access/hash/hashsort.c
index 2c7b5857b53..b04b26e4c0b 100644
--- a/src/backend/access/hash/hashsort.c
+++ b/src/backend/access/hash/hashsort.c
@@ -146,6 +146,9 @@ _h_indexbuild(HSpool *hspool, Relation heapRel)
 
 		_hash_doinsert(hspool->index, itup, heapRel);
 
+		/* allow insertion phase to be interrupted, and track progress */
+		CHECK_FOR_INTERRUPTS();
+
 		pgstat_progress_update_param(PROGRESS_CREATEIDX_TUPLES_DONE,
 									 ++tups_done);
 	}