Skip to content

Conversation

@Yannic
Copy link
Contributor

@Yannic Yannic commented Mar 20, 2021

This makes it compatible with absl::uint128

This makes it compatible with absl::uint128
@acozzette acozzette merged commit b604419 into protocolbuffers:master Mar 30, 2021
@acozzette
Copy link

Thanks, @Yannic.

@lipnitsk
Copy link

lipnitsk commented Apr 1, 2021

This broke external code depending on descriptor.pb.h.

Step #4: In file included from /src/protobuf-install/include/google/protobuf/descriptor.pb.h:23:
Step #4: In file included from /src/protobuf-install/include/google/protobuf/io/coded_stream.h:148:
Step #4: /src/protobuf-install/include/google/protobuf/stubs/logging.h:34:10: fatal error: 'google/protobuf/stubs/int128.h' file not found
Step #4: #include <google/protobuf/stubs/int128.h>
Step #4:          ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~

Link: https://bugs.chromium.org/p/oss-fuzz/issues/detail?id=32763
Link: https://oss-fuzz-build-logs.storage.googleapis.com/log-b9d0c99a-00b5-4af7-862c-f16a5a11c457.txt

acozzette pushed a commit to acozzette/protobuf that referenced this pull request Apr 2, 2021
@acozzette
Copy link

@lipnitsk Thanks for the heads-up, let's roll back this change until we have a chance to come up with a fix. I will sent out a pull request in just a second.

acozzette pushed a commit that referenced this pull request Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants