Skip to content

Conversation

@MuellerSeb
Copy link
Member

fixes #377

pnt_cnt was not recalculated in vario_estimate when a mask was applied. Together with a given sample size, this resulted in an IndexError most of the times.

@MuellerSeb MuellerSeb added the bug Something isn't working label Feb 8, 2025
@MuellerSeb MuellerSeb added this to the 1.7 milestone Feb 8, 2025
@MuellerSeb MuellerSeb self-assigned this Feb 8, 2025
@MuellerSeb MuellerSeb requested a review from LSchueler February 8, 2025 16:03
Copy link
Member

@LSchueler LSchueler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@MuellerSeb MuellerSeb merged commit bfcb495 into main Feb 10, 2025
33 checks passed
@MuellerSeb MuellerSeb deleted the bugfix_vario_estimate_mask_sample branch February 10, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Possible unexpected behaviour of gs.vario_estimate with masked fields

3 participants