Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: GoogleCloudPlatform/java-repo-tools
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.0.13
Choose a base ref
...
head repository: GoogleCloudPlatform/java-repo-tools
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.0.14
Choose a head ref
  • 3 commits
  • 3 files changed
  • 1 contributor

Commits on Mar 24, 2020

  1. Setup for next version (#117)

    @lesv
    lesv authored Mar 24, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    d45ce4e View commit details

Commits on Mar 30, 2020

  1. Add in SpotBugs plugin (#118) 

    * Add in SpotBugs plugin

Yet another stackic checker.
Fixes #78

* Let's use real versions

* Upgrade checkstyle version
    @lesv
    lesv authored Mar 30, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    1e4dbcb View commit details

  2. Prepare for release 1.0.14 (#120)

    @lesv
    lesv authored Mar 30, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    GPG key ID: 4AEE18F83AFDEB23
    Expired
    Verified
    Learn about vigilant mode
    Copy the full SHA
    98b3756 View commit details
Showing with 36 additions and 19 deletions.
  1. +2 −2 checkstyle-config/pom.xml
  2. +32 −15 pom.xml
  3. +2 −2 test/pom.xml
4 changes: 2 additions & 2 deletions checkstyle-config/pom.xml
View file
Original file line number Diff line number Diff line change
@@ -18,7 +18,7 @@ limitations under the License.

<groupId>com.google.cloud.samples</groupId>
<artifactId>checkstyle-configuration</artifactId>
<version>1.0.13</version>
<version>1.0.14</version>
<packaging>jar</packaging>

<name>${project.groupId}:${project.artifactId}</name>
@@ -63,7 +63,7 @@ limitations under the License.
<url>https://github.com/GoogleCloudPlatform/java-repo-tools</url>
<connection>scm:git:https://github.com/GoogleCloudPlatform/java-repo-tools.git</connection>
<developerConnection>scm:git:ssh://git@github.com/GoogleCloudPlatform/java-repo-tools.git</developerConnection>
<tag>v1.0.13-snapshot</tag>
<tag>v${project.version}</tag>
</scm>

<distributionManagement>
47 changes: 32 additions & 15 deletions pom.xml
View file
Original file line number Diff line number Diff line change
@@ -16,9 +16,15 @@ limitations under the License.
<project xmlns="http://maven.apache.org/POM/4.0.0" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<javac.version>9+181-r4173-1</javac.version>
</properties>

<groupId>com.google.cloud.samples</groupId>
<artifactId>shared-configuration</artifactId>
<version>1.0.13</version>
<version>1.0.14</version>
<packaging>pom</packaging>

<name>${project.groupId}:${project.artifactId}</name>
@@ -67,7 +73,7 @@ limitations under the License.
<connection>scm:git:git@github.com:GoogleCloudPlatform/java-repo-tools.git</connection>
<developerConnection>scm:git:git@github.com:GoogleCloudPlatform/java-repo-tools.git</developerConnection>
<url>git@github.com:GoogleCloudPlatform/java-repo-tools.git</url>
<tag>v1.0.13</tag>
<tag>v${project.version}</tag>
</scm>

<distributionManagement>
@@ -81,12 +87,6 @@ limitations under the License.
</repository>
</distributionManagement>

<properties>
<project.build.sourceEncoding>UTF-8</project.build.sourceEncoding>
<project.reporting.outputEncoding>UTF-8</project.reporting.outputEncoding>
<javac.version>9+181-r4173-1</javac.version>
</properties>

<profiles>
<!-- Code signing for release: http://stackoverflow.com/a/14869692/101923 -->
<profile>
@@ -108,11 +108,6 @@ limitations under the License.
</executions>
</plugin>

<plugin>
<artifactId>maven-archetype-plugin</artifactId>
<version>3.1.2</version>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-gpg-plugin</artifactId>
@@ -209,6 +204,28 @@ limitations under the License.
</configuration>
</plugin>

<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<version>4.0.0</version>
<executions>
<execution>
<phase>verify</phase>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
<dependencies>
<!-- overwrite dependency on spotbugs if you want to specify the version of spotbugs -->
<dependency>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs</artifactId>
<version>4.0.1</version>
</dependency>
</dependencies>
</plugin>

<plugin> <!-- Style Check -->
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
@@ -229,12 +246,12 @@ limitations under the License.
<dependency>
<groupId>com.google.cloud.samples</groupId>
<artifactId>checkstyle-configuration</artifactId>
<version>1.0.13</version>
<version>1.0.14</version>
</dependency>
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
<version>8.30</version>
<version>8.31</version>
</dependency>
</dependencies>
<executions>
4 changes: 2 additions & 2 deletions test/pom.xml
View file
Original file line number Diff line number Diff line change
@@ -26,7 +26,7 @@ limitations under the License.
<parent>
<artifactId>shared-configuration</artifactId>
<groupId>com.google.cloud.samples</groupId>
<version>1.0.13</version>
<version>1.0.14</version>
<relativePath>..</relativePath>
</parent>

@@ -46,7 +46,7 @@ limitations under the License.
<dependency>
<groupId>com.google.truth</groupId>
<artifactId>truth</artifactId>
<version>0.37</version>
<version>1.0.1</version>
<scope>test</scope>
</dependency>
</dependencies>