Skip to content

feat: add Tunneling cluster commands #1381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Koenkk merged 4 commits into from
Apr 5, 2025
Merged

feat: add Tunneling cluster commands #1381

Koenkk merged 4 commits into from
Apr 5, 2025

Conversation

@avzasorin-sd
Copy link
Contributor

@avzasorin-sd avzasorin-sd commented Apr 2, 2025

Extend cluster.ts with mandatory commands of Tunneling cluster, which are described in ZCL specification ( ZCLv8 10.6.2.4 and 10.6.2.5 )

Koenkk
Koenkk reviewed Apr 2, 2025
View reviewed changes
src/zspec/zcl/definition/cluster.ts Outdated
ID: 0,
response: 0,
parameters: [
{name: 'protocolID', type: DataType.ENUM8},
Copy link
Owner

@Koenkk Koenkk Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{name: 'protocolID', type: DataType.ENUM8},
{name: 'protocolId', type: DataType.ENUM8},

To keep it consistent with other Ids in this file (also change other occurrences below)

Copy link
Contributor Author

@avzasorin-sd avzasorin-sd Apr 3, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There was tunnelID in description of transferData and transferDataResp commands already, it was added before my PR.
Should I change only protocolID to protocolId, because tunnelID key is used by easyiot.ts converter - and I was following this notation as an example.

Copy link
Owner

@Koenkk Koenkk Apr 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's also update easyiot.ts for consistency purposes.

@avzasorin-sd avzasorin-sd mentioned this pull request Apr 4, 2025
Merged
@avzasorin-sd
Copy link
Contributor Author

avzasorin-sd commented Apr 4, 2025

Done with naming style. Created related PR to ZHC, because otherwise it will break easyiot.ts converter
Koenkk/zigbee-herdsman-converters#9118

@Koenkk Koenkk merged commit 5bf6b40 into Koenkk:master Apr 5, 2025
1 check passed
@Koenkk
Copy link
Owner

Koenkk commented Apr 5, 2025

Thanks!

@Koenkk Koenkk mentioned this pull request Apr 5, 2025
Merged
CubeZ2mDeveloper added a commit to CubeZ2mDeveloper/zigbee-herdsman that referenced this pull request Jun 30, 2025
@CubeZ2mDeveloper
Squashed commit of the following:
005a478 
commit da4f831
Author: Koen Kanters <[email protected]>
Date:   Sat Jun 28 10:21:08 2025 +0200

    chore(master): release 4.2.1 (Koenkk#1429)

commit 8a134cc
Author: Manuel Pietschmann <[email protected]>
Date:   Sat Jun 28 10:18:47 2025 +0200

    fix: deCONZ: handle race condition between APS confirm/indication timeouts (Koenkk#1432)

commit 33e708d
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Jun 24 21:47:54 2025 +0200

    fix(ignore): bump the minor-patch group with 2 updates (Koenkk#1430)

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit a4d7b19
Author: Koen Kanters <[email protected]>
Date:   Mon Jun 23 20:48:46 2025 +0200

    fix(ignore): Migrate to Biome 2 (Koenkk#1427)

commit 8668dee
Author: Koen Kanters <[email protected]>
Date:   Sun Jun 22 22:11:33 2025 +0200

    chore(master): release 4.2.0 (Koenkk#1426)

commit 73a2548
Author: Nerivec <[email protected]>
Date:   Sun Jun 22 12:21:46 2025 +0200

    feat: Support for EmberZNet 8.2.0 (EZSP v17 / v2025.6.0) (Koenkk#1428)

commit c719ee4
Author: Manuel Pietschmann <[email protected]>
Date:   Thu Jun 19 20:17:13 2025 +0200

    feat: Refactor and improve of Deconz adapter (Koenkk#1417)

    Co-authored-by: Koen Kanters <[email protected]>

commit 99b6c97
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Jun 17 14:42:07 2025 +0200

    fix(ignore): bump @types/node from 22.15.30 to 24.0.3 (Koenkk#1425)

commit 7beb12c
Author: Koen Kanters <[email protected]>
Date:   Sun Jun 15 13:44:18 2025 +0200

    chore(master): release 4.1.2 (Koenkk#1420)

commit 172d543
Author: jomders <[email protected]>
Date:   Sun Jun 15 19:42:40 2025 +0800

    fix: Fix interview failing for HOBEIAN devices (Koenkk#1422)

    Co-authored-by: Koen Kanters <[email protected]>

commit 29815bd
Author: Koen Kanters <[email protected]>
Date:   Tue Jun 10 20:25:06 2025 +0200

    chore: bump pnpm

commit 0a9a1c7
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Tue Jun 10 20:11:57 2025 +0200

    fix(ignore): bump the minor-patch group with 3 updates (Koenkk#1419)

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 2da206d
Author: Koen Kanters <[email protected]>
Date:   Fri Jun 6 22:10:28 2025 +0200

    chore(master): release 4.1.1 (Koenkk#1415)

commit f465823
Author: puddly <[email protected]>
Date:   Fri Jun 6 21:08:10 2025 +0100

    fix: Enable serial port locking by default for ZiGate (Koenkk#1380)

commit 949a08c
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Jun 2 19:51:32 2025 +0200

    fix(ignore): bump the minor-patch group with 2 updates (Koenkk#1416)

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 534cff5
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Sat May 31 12:46:54 2025 +0200

    fix(ignore): bump @types/node from 22.15.21 to 22.15.29 in the minor-patch group (Koenkk#1414)

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 6ea8348
Author: Koen Kanters <[email protected]>
Date:   Sat May 31 12:34:25 2025 +0200

    chore: update dependabot config

commit 56d010a
Author: Nerivec <[email protected]>
Date:   Thu May 29 12:45:30 2025 +0200

    chore: update ZoH dep (Koenkk#1413)

commit 204b7db
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon May 26 20:31:36 2025 +0200

    chore(deps-dev): bump @types/node from 22.15.19 to 22.15.21 in the minor-patch group (Koenkk#1412)

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 73b8efa
Author: Koen Kanters <[email protected]>
Date:   Tue May 20 21:18:46 2025 +0200

    chore(master): release 4.1.0 (Koenkk#1409)

commit cc889b0
Author: Koen Kanters <[email protected]>
Date:   Tue May 20 17:09:23 2025 +0200

    feat: Add conditional fieldControl fields to genOta commands (Koenkk#1408)

commit c316b58
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon May 19 20:37:09 2025 +0200

    chore(deps-dev): bump the minor-patch group with 3 updates (Koenkk#1407)

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    Co-authored-by: Koen Kanters <[email protected]>

commit 797aeca
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon May 12 19:31:19 2025 +0200

    chore(deps-dev): bump @types/node from 22.15.3 to 22.15.17 in the minor-patch group (Koenkk#1406)

commit c937bb7
Author: Koen Kanters <[email protected]>
Date:   Sun May 11 21:28:35 2025 +0200

    chore(master): release 4.0.2 (Koenkk#1404)

commit bd1be3f
Author: Koen Kanters <[email protected]>
Date:   Sun May 11 21:25:13 2025 +0200

    fix(ignore): fix tests

commit 35c34b2
Author: Koen Kanters <[email protected]>
Date:   Sun May 11 15:32:41 2025 +0200

    chore(master): release 4.0.1 (Koenkk#1398)

commit a82b79f
Author: Koen Kanters <[email protected]>
Date:   Sun May 11 15:31:58 2025 +0200

    fix: ZStack: add additional logging when comparing adapter state with config Koenkk#1403

commit da33fbc
Author: Koen Kanters <[email protected]>
Date:   Wed May 7 21:18:13 2025 +0200

    chore: bump node in CI to 24

commit 2205715
Author: Koen Kanters <[email protected]>
Date:   Mon May 5 19:52:07 2025 +0200

    chore: fully switch to Dependabot

commit 988f788
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon May 5 19:41:34 2025 +0200

    chore(deps-dev): bump the minor-patch group with 2 updates (Koenkk#1401)

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 45f6da4
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Apr 28 21:06:30 2025 +0200

    chore(deps-dev): bump @types/node from 22.14.1 to 22.15.3 in the minor-patch group (Koenkk#1400)

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 0ddc009
Author: Nerivec <[email protected]>
Date:   Sat Apr 26 20:21:21 2025 +0200

    fix: Add support for generic science-related clusters (Koenkk#1396)

commit a56a776
Author: Koen Kanters <[email protected]>
Date:   Tue Apr 22 21:15:15 2025 +0200

    chore(master): release 4.0.0 (Koenkk#1393)

commit b9e86b0
Author: Koen Kanters <[email protected]>
Date:   Tue Apr 22 21:14:25 2025 +0200

    feat!: Expose interviewState (Koenkk#1391)

commit b09f8e9
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Apr 21 21:23:28 2025 +0200

    chore(deps-dev): bump the minor-patch group with 2 updates (Koenkk#1395)

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit f4f8535
Author: Koen Kanters <[email protected]>
Date:   Sat Apr 19 21:06:33 2025 +0200

    chore: Biome ignore `package.json`

commit bc30e84
Author: Koen Kanters <[email protected]>
Date:   Sat Apr 19 20:56:51 2025 +0200

    fix!: Migrate to Biome (Koenkk#1387)

    Co-authored-by: Nerivec <[email protected]>

commit d4b3eea
Author: Koen Kanters <[email protected]>
Date:   Fri Apr 18 09:50:40 2025 +0200

    chore(master): release 3.5.2 (Koenkk#1389)

commit e9b6bc9
Author: Nerivec <[email protected]>
Date:   Fri Apr 18 00:52:06 2025 +0200

    fix(ignore): Update ZoH to v0.1.11 (Koenkk#1392)

commit caa3231
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Mon Apr 14 22:02:01 2025 +0200

    chore(deps-dev): bump typescript-eslint from 8.29.1 to 8.30.0 in the minor-patch group (Koenkk#1390)

    Signed-off-by: dependabot[bot] <[email protected]>
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

commit 0dd3554
Author: Koen Kanters <[email protected]>
Date:   Sun Apr 13 21:33:43 2025 +0200

    chore: lint

commit b288ab9
Author: Koen Kanters <[email protected]>
Date:   Sun Apr 13 21:13:02 2025 +0200

    chore: enable dependabot

commit 8d2da3a
Author: Koen Kanters <[email protected]>
Date:   Sun Apr 13 20:53:26 2025 +0200

    fix(ignore): update dependencies (Koenkk#1388)

commit 4911b7e
Author: Koen Kanters <[email protected]>
Date:   Sun Apr 6 21:16:38 2025 +0200

    chore(master): release 3.5.1 (Koenkk#1385)

commit 573641b
Author: Nerivec <[email protected]>
Date:   Sun Apr 6 21:05:30 2025 +0200

    fix: Improve Green Power processing (Koenkk#1386)

commit 9e92522
Author: Koen Kanters <[email protected]>
Date:   Sun Apr 6 15:37:16 2025 +0200

    fix(ignore): update dependencies (Koenkk#1384)

commit 8f15950
Author: Koen Kanters <[email protected]>
Date:   Sat Apr 5 13:57:22 2025 +0200

    chore(master): release 3.5.0 (Koenkk#1383)

commit 5bf6b40
Author: avzasorin-sd <[email protected]>
Date:   Sat Apr 5 14:41:58 2025 +0300

    feat: add Tunneling cluster commands (Koenkk#1381)

    Co-authored-by: Koen Kanters <[email protected]>

commit 236da5b
Author: avzasorin-sd <[email protected]>
Date:   Thu Apr 3 21:04:46 2025 +0300

    feat: add SberDevices manufacturer code (Koenkk#1382)

    Co-authored-by: Koen Kanters <[email protected]>

commit 38d2885
Author: CubeZ2mDeveloper <[email protected]>
Date:   Thu Apr 3 01:47:10 2025 +0800

    fix: Support for Sonoff Dongle Max auto-discovery (Koenkk#1378)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Koenkk Koenkk Koenkk left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@avzasorin-sd @Koenkk