fix: deCONZ: Joining bug in some setups and endpoint configuration #1445
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes pairing devices due a bug in which ZGP endpoint wasn't configured in some setups which were around for a long time. The old adapter didn't bail out since the error was silently ignored. Configuring the endpoints never worked prior to this PR. So only the shipping firmware default endpoints where available. This also fixes sending out ZGP proxy commissioning commands for the setups in which no ZGP endpoint was configured before. Tested with ConBee 1, 2 and 3. Issue: Koenkk/zigbee2mqtt#27902
Owner
|
Thanks for all the quick fixes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes pairing devices due a bug in which ZGP endpoint wasn't configured in some setups which were around for a long time.
The old adapter didn't bail out since the error was silently ignored. Configuring the endpoints never worked prior to this PR. So only the shipping firmware default endpoints where available.
This also fixes sending out ZGP proxy commissioning commands for the setups in which no ZGP endpoint was configured before.
Tested with ConBee 1, 2 and 3.
Issue: Koenkk/zigbee2mqtt#27902