-
Notifications
You must be signed in to change notification settings - Fork 356
feat!: add new bind/reporting/map features #1561
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@Nerivec ready for merge? |
|
Should be good! |
|
Why was the map information changed in a way that generates a breaking change, when this was (from what I see) completely needless ? I have grabbed Routing and LQI information from a small network with ZH 6.4 and 7.0 to compare - both the change in format and the renaming of certain pieces of information generate unneeded breaking changes. I would like to understand the reason for this - and if it makes sense to update the underlying data now or wait since more of these changes are in the works. see the comparison below as to what I mean: 6.4 Structure, LQI: 7.0 Structure (LQI), same device) What irritates me especially is:
Omitting the enclosing object with its Something similar was done to the These changes basically require code changes in libraries which use the respective functions, |
|
It's a cleanup of the old format used before the ZDO revamp months ago. We were still creating objects, remapping needlessly, had duplicated typing, etc. The API now uses the ZDO data directly, avoiding all this, and automatically providing the extra data that was omitted before. |
Thanks for clarifying this. Can you give me a rough idea which areas of the ZH interface / routines are next on the list, so I can prepare the zigbee adapter for the coming change - it makes it a lot easier for me if I have an idea what is coming. A. |
|
We mark PRs with |
lqi&routingTablereadReportConfigRspconditionsFor Foundation
configReportRsp, some of the tests look wrong in their expected payloads (mix statuses):[{status: 0x00}][{status: 0x01, direction: 0x01, attrId: 0x1234}, {status: 0x02, direction: 0x00, attrId: 0x4321}]Though from #115 (comment) looks like some devices may not be following this properly.