-
Notifications
You must be signed in to change notification settings - Fork 356
Fix parsing of payload for configReportRsp #115
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
3b3697f to
131ab79
Compare
|
@Koenkk I suspect the failing test is incorrect. Also I'm wordering if the parsing should be |
|
@carldebilly thanks for the PR, unfortunately I'm on holiday now, will dive into it after. |
|
You're right: it's breaking somewhere else. |
The parsing of the payload for `configReportRsp` was incorrect and leading to `raw` packet type in `zigbee2mqtt` as defined in this comment: Koenkk/zigbee2mqtt#2058 (comment)
|
@Koenkk Ok I fixed the problem. Now the payload is "optional" but when present, it won't crash the parsing as before. |
|
The parsing should definitely repetitive, otherwise when multiple status records are returned only this first one will be parsed. I've updated the PR to do this, test are OK now. @carldebilly let me know if this is ok for you then this can be merged. |
|
I'm confortable with those changes. |
|
Awesome, thanks! |



The parsing of the payload for
configReportRspwas incorrect and leading torawpacket type inzigbee2mqttas defined in this comment: Koenkk/zigbee2mqtt#2058 (comment)✔️ Also include mfgr clusters for Stelpro