Skip to content

feat: support for more install code formats #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
Koenkk merged 1 commit into from
Jul 4, 2025
Merged

feat: support for more install code formats #1444

Koenkk merged 1 commit into from
Jul 4, 2025

Conversation

@Nerivec
Copy link
Collaborator

@Nerivec Nerivec commented Jul 4, 2025

  • improved regexes to ensure proper match
  • added more regexes (pulled from various discussions/issues)
  • moved checkInstallCode out of ZSpec and into Controller helpers, next to new parseInstallCode

fixes #1402

@Nerivec Nerivec requested a review from Koenkk July 4, 2025 11:53
@Koenkk Koenkk merged commit aeec6d6 into Koenkk:master Jul 4, 2025
1 check passed
@Koenkk
Copy link
Owner

Koenkk commented Jul 4, 2025

Thanks!

@Koenkk Koenkk mentioned this pull request Jul 4, 2025
Merged
@Nerivec Nerivec deleted the install-codes branch July 4, 2025 12:15
@InovelliUSA InovelliUSA mentioned this pull request Jul 4, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Koenkk Koenkk Awaiting requested review from Koenkk

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Supporting Inovelli install codes

2 participants

@Nerivec @Koenkk