Skip to content

Conversation

@Nerivec
Copy link
Collaborator

@Nerivec Nerivec commented Apr 10, 2025

  • Call onEvent stop when device leaves (ensures cleared timers, no use of stale refs)
  • Pass proper data to onEvent
  • Fix deviceExposesChanged using Zh.Device instead of Device (used by HA discovery, KeyValue typing was hiding it)
    • looks like a test for HA extension should be added to cover this
  • Use Map for Device/Group lookups
  • Fix resolveGroup typing possibly undefined
  • Rewrite OnEvent tests

Rest is mostly pre-emptive strikes for biome move.

@Koenkk Koenkk merged commit 80502da into Koenkk:dev Apr 10, 2025
11 checks passed
@Nerivec Nerivec deleted the leave-onevent-stop branch April 17, 2025 23:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants