Skip to content

Conversation

@Koenkk
Copy link
Owner

@Koenkk Koenkk commented May 5, 2025

No description provided.

@Koenkk Koenkk requested a review from Nerivec May 5, 2025 19:52
@Nerivec
Copy link
Collaborator

Nerivec commented May 6, 2025

Should also fix the API:

"bridge/request/device/bind": {
from: string;
from_endpoint: string | number | "default";
to: string;
to_endpoint?: string | number;
clusters?: string[];
skip_disable_reporting?: boolean;
};
"bridge/response/device/bind": {
from: string;
from_endpoint: string | number;
to: string;
to_endpoint: string | number | undefined;
clusters: string[];
failed: string[];
};
"bridge/request/device/unbind": {
from: string;
from_endpoint: string | number | "default";
to: string;
to_endpoint?: string | number;
clusters?: string[];
skip_disable_reporting?: boolean;
};
"bridge/response/device/unbind": {
from: string;
from_endpoint: string | number;
to: string;
to_endpoint: string | number | undefined;
clusters: string[];
failed: string[];
};

to should be string | number (friendly_name, ieee, group id).

And (for that other bug)

const resolvedTarget = message.to === DEFAULT_BIND_GROUP.name ? DEFAULT_BIND_GROUP : this.zigbee.resolveEntity(message.to);

I believe should be

const resolvedTarget = message.to === DEFAULT_BIND_GROUP.name || message.to === DEFAULT_BIND_GROUP.ID ? DEFAULT_BIND_GROUP : this.zigbee.resolveEntity(message.to);

@Koenkk Koenkk merged commit d8855b8 into dev May 7, 2025
24 checks passed
@Koenkk Koenkk deleted the fix/coordinator-by-ieeeaddr branch May 7, 2025 19:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants