feat: allow to disable internal frontend UI serving for standalone serving #27851
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6f56428 to
c073685
Compare
Owner
When there are no device_icons the deviceIconsFileServer is never called, so I guess that is why it doesn't give any problems.
I think the standalone server should be responsible for serving in this case |
Koenkk
approved these changes
Jul 9, 2025
b270166 to
16bde5a
Compare
Owner
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to disable internal serving for standalone frontend use cases (e.g.).
Also:
express-static-gziprelated stuff - @bdolgov can you double-check things related to previous issues (has been fixed for a while from what I saw in PRs)?TODO:
data.joinPath("device_icons")exists, how does that affectdeviceIconsFileServerhandler?device_iconsserving + standalone frontend serving