Skip to content

Conversation

@Koenkk
Copy link
Owner

@Koenkk Koenkk commented Jul 14, 2025

This PR:

Requires Koenkk/zigbee-herdsman-converters#9693 and Koenkk/zigbee-herdsman-converters#9650

@Koenkk Koenkk marked this pull request as ready for review July 14, 2025 11:43
@Koenkk Koenkk requested a review from Nerivec July 14, 2025 11:43
@Koenkk Koenkk changed the title fix: Call definition onEvent stop when device is removed fix: Update to new zhc onEvent() API Jul 26, 2025
@Koenkk Koenkk changed the title fix: Update to new zhc onEvent() API fix: Update to refactored zhc onEvent() and postProcessConvertedFromZigbeeMessage() API and fix onEvent(stop) not being called when device is removed Jul 26, 2025
@Koenkk Koenkk changed the title fix: Update to refactored zhc onEvent() and postProcessConvertedFromZigbeeMessage() API and fix onEvent(stop) not being called when device is removed fix: Update to refactored zhc onEvent() and postProcessConvertedFromZigbeeMessage() API and fix onEvent(stop) not being called when device is force removed Jul 26, 2025
@Koenkk Koenkk changed the title fix: Update to refactored zhc onEvent() and postProcessConvertedFromZigbeeMessage() API and fix onEvent(stop) not being called when device is force removed fix: Update to refactored zhc onEvent() API and fix onEvent(stop) not being called when device is force removed Jul 26, 2025
@Koenkk Koenkk changed the title fix: Update to refactored zhc onEvent() API and fix onEvent(stop) not being called when device is force removed fix: Update to refactored zhc onEvent() and fix onEvent(stop) not being called when device is force removed Jul 26, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Aug 11, 2025

CodSpeed Performance Report

Merging #27984 will not alter performance

Comparing fix/on-event-stop-device-remove (4f508cd) with dev (bd1be88)1

Summary

✅ 9 untouched benchmarks

Footnotes

  1. No successful run was found on dev (3160219) during the generation of this report, so bd1be88 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@Koenkk Koenkk merged commit 5286570 into dev Aug 11, 2025
14 checks passed
@Koenkk Koenkk deleted the fix/on-event-stop-device-remove branch August 11, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants