-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
fix: Remove Moment.js dependency #28797
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+6
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the Moment.js dependency from the codebase and replaces it with a custom formatTimestamp function to reduce bundle size and eliminate reliance on a legacy library.
Key changes:
- Implemented a lightweight
formatTimestampfunction that supports common date formatting tokens - Replaced all Moment.js usage in the logger with the new function
- Added comprehensive test coverage for the new formatting function
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| package.json | Removes the moment dependency from the project |
| lib/util/utils.ts | Adds the new formatTimestamp function implementation |
| lib/util/logger.ts | Replaces moment calls with the new formatTimestamp function |
| test/utils.test.ts | Adds comprehensive test cases for the new formatting function |
| test/utils.bench.ts | Adds performance benchmark tests for the new function |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
Nerivec
reviewed
Oct 1, 2025
Nerivec
reviewed
Oct 1, 2025
seuros
approved these changes
Oct 5, 2025
Nerivec
approved these changes
Oct 6, 2025
cbc4a92 to
09cda8e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove dependency on Moment.js as it's considered legacy and we can easily replace the functionality that is used with a simple function.
This is potentially breaking as we don't support all tokens supported by Moment.js (but I don't expect it's used). Let's add more once we find users using it.