fix: Fix onEvent called twice first time when device options are changed
#29322
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nerivec
reviewed
Oct 27, 2025
Comment on lines
-187
to
-188
| expect(onEventSpy).toHaveBeenCalledTimes(2); | ||
| expect(deviceOnEventSpy).toHaveBeenCalledTimes(1); |
Collaborator
There was a problem hiding this comment.
Was this removal intended? It doesn't appear to check anything anymore (except that the test doesn't timeout).
Owner
Author
There was a problem hiding this comment.
yes it's because the clear isn't done anymore the event spy is now called 6 times. What is called and how often is already checked in the test case above so not much value to do it again here.
Nerivec
reviewed
Oct 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Koenkk/zigbee-herdsman-converters#10520