TypeError • e[0].toFixed is not a function • Dashboard

[skvarel]

Describe the bug

To Reproduce

Klick on dashboard tab

Expected behavior

No response

Affected browsers

Firefox

Stacktrace

**Current url**: http://192.168.130.120:8081/?instance=0&newReact=true&0&react=dark#/dashboard
**Previous url**: http://192.168.130.130:8081/


**Error type**: TypeError
**Error message**: e[0].toFixed is not a function



Ne@http://192.168.130.120:8081/assets/Feature-Dn8iv4tk.js:1:9577
de@http://192.168.130.120:8081/assets/Feature-Dn8iv4tk.js:1:9791
we<@http://192.168.130.120:8081/assets/Feature-Dn8iv4tk.js:1:10894
uh@http://192.168.130.120:8081/assets/index-vDL8KyrI.js:52:34204
Oh@http://192.168.130.120:8081/assets/index-vDL8KyrI.js:52:62634
BS@http://192.168.130.120:8081/assets/index-vDL8KyrI.js:52:61542
FS@http://192.168.130.120:8081/assets/index-vDL8KyrI.js:52:61090
QS@http://192.168.130.120:8081/assets/index-vDL8KyrI.js:52:75614
wA@http://192.168.130.120:8081/assets/index-vDL8KyrI.js:52:107335
Bz@http://192.168.130.120:8081/assets/index-vDL8KyrI.js:52:106394
Zh@http://192.168.130.120:8081/assets/index-vDL8KyrI.js:52:106222
pA@http://192.168.130.120:8081/assets/index-vDL8KyrI.js:52:103313
PA@http://192.168.130.120:8081/assets/index-vDL8KyrI.js:52:114820
B@http://192.168.130.120:8081/assets/index-vDL8KyrI.js:21:1580
@http://192.168.130.120:8081/assets/index-vDL8KyrI.js:11:15272
F@http://192.168.130.120:8081/assets/index-vDL8KyrI.js:11:15030
H@http://192.168.130.120:8081/assets/index-vDL8KyrI.js:11:15090

[Nerivec]

Can you attach the state file as indicated so I can see which device's state is causing this?

[skvarel]

state.json

[Nerivec]

@Koenkk looks like ZHC sometimes send color.x / color.y (maybe others?) as string instead of number and sometimes not:

// "manufacturer": "GLEDOPTO",
// "model_id": "GL-MC-001P",
"340a BAR-Stripe": {
    "brightness": 254,
    "color": {
        "hue": 18,
        "saturation": 100,
        "x": "0.5860",
        "y": "0.3964"
    },
    "color_mode": "xy",
    "color_temp": 584,
    "color_temp_startup": 17476,
},
// "manufacturer": "IKEA of Sweden",
// "model_id": "TRADFRI bulb E14 CWS opal 600lm",
"340a Strand RGB": {
    "brightness": 50,
    "color": {
        "hue": 18,
        "saturation": 100,
        "x": "0.5860",
        "y": "0.3964"
    },
    "color_mode": "xy",
    "color_temp": 584,
},
// "manufacturer": "_TZ3210_w7ge4ldo",
// "model_id": "TS0503B",
"inventwo Deko Stripe": {
    "brightness": 254,
    "color": {
        "x": "0.5860",
        "y": "0.3964"
    },
    "color_mode": "xy",
    "color_power_on_behavior": "previous",
},
// "manufacturer": "_TZ3210_w7ge4ldo",
// "model_id": "TS0503B",
"Wohnzimmer EG TV Stripe": {
    "brightness": 254,
    "color": {
        "x": "0.4262",
        "y": "0.2868"
    },
    "color_mode": "xy",
},

// "manufacturer": "OSRAM",
// "model_id": "Gardenpole Mini RGBW OSRAM",
"340a Steg LED": {
    "brightness": 0,
    "color": {
        "hue": 1,
        "saturation": 100,
        "x": 0.6924,
        "y": 0.3062
    },
    "color_mode": "hs",
    "color_temp": 181,
},

Looks like the library the old frontend uses for colors has built-in parsing when it comes in as strings, but I think this should be fixed in ZHC so the API is consistent.

[skvarel]

Currently I use the old fontend, which also runs with z2m v2.4.0

But I would like to test the windfront

[Koenkk]

@skvarel could you provide the debug log when changing the color of one of these devices (except last one)?

See this on how to enable debug logging.

[Nerivec]

I wasn't able to trace where those numbers are being swapped to strings in ZHC.
I guess we'll need those logs to figure it out, though I wonder if they could be from an earlier ZHC version (stale state)? @skvarel can you confirm the color on these first four devices has been changed recently?

[Patrick12300]

I noticed the problem too.
It happens when I change or reapply the color object in iobroker. It seems like that the ioBroker.zigbee2mqtt adapter is the problem.
iob.txt

The problem gets solved when I change the values manually (remove the "") in the state.json and restart the Zigbee2MQTT broker.

Secondly, when I change the value in winfront, the value gets rechanged from ioBroker.zigbee2mqtt multiple times, I changed the color just once.
The iobon.txt is with the adapter ioBroker.zigbee2mqtt open and ioboff.txt is with ioBroker.zigbee2mqtt closed.
ioboff.txt
iobon.txt

ioBroker.zigbee2mqtt v3.0.8
zigbee2mqtt 2.4.0 (bridge)
Zigbee2MQTT\node_modules\zigbee-herdsman-converters [23.53.0] (bridge)

Maybe the error is in the rgb.js in iobroker.zigbee2mqtt?
let x = (X / (X + Y + Z)).toFixed(4);
let y = (Y / (X + Y + Z)).toFixed(4);

[Nerivec]

That could do it if it's overriding the published data (toFixed for sure creates a string). I don't know iobroker at all though.

[Koenkk]

Fixed the issue! (will do a conversion from string -> number)

Changes will be available in the dev branch in a few hours from now and in the next release which is every 1st of the month.

[skvarel]

I'll test it tomorrow and get back to you

[skvarel]

state.json

[Nerivec]

@skvarel You'll probably have to delete the zigbee2mqtt/data/state.json to test this properly, because until the values are re-applied they will keep being strings, or you can manually modify the 4 JSON entries I posted above, make the strings numbers by taking out the quotes.
Example

"x": "0.5860",

becomes

"x": 0.5860,