nix flake show: Skip IFDs instead of throwing#12583
Merged
Merged
Conversation
Mic92
reviewed
Mar 11, 2025
Contributor
|
From meeting: Not sure about adding a dedicated flag that is so similar to an existing flag + option. Let's start with only the descriptive warning that the output is omitted. |
tomberek
approved these changes
Mar 26, 2025
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nix-2-29-0-released/64609/1 |
13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
As mentioned in #4265 (comment),
nix flake showfails if it encounters an IFD while it's trying to show the derivations inside the flake. This means thatnix flake showis effectively broken if you are using IFD's in almost any place in your flake.Context
Following
--all-systems,nix flake shownow shows an "omitted" message when it encounters an IFD. To this end, I gave IFD errors an explicit type that made this possible.Example output with this patch:
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.