repl: improve continuation prompt for incomplete expressions#12846
Merged
Conversation
Previously, when users entered an incomplete expression in the REPL, the continuation prompt was just 10 blank spaces, which looked invisible and gave the impression that the REPL had stalled. This change updates the prompt to " > ", aligning it visually with 'nix-repl> ' and clearly indicating that the REPL is waiting for more input. Fixes: NixOS#12702
Member
|
Thanks! |
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/nix-2-29-0-released/64609/1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This PR improves the REPL experience by making it clearer when the user is entering an incomplete expression.
Previously, when users entered an incomplete expression in the REPL, the continuation prompt was just 10 blank spaces, which looked invisible and gave the impression that the REPL had stalled or was unresponsive.
This change updates the prompt to
" > ", aligning it visually with'nix-repl> 'and clearly indicating that the REPL is waiting for more input.Context
Fixes: #12702
The continuation prompt logic already existed (
ReplPromptType::ContinuationPrompt) but used a prompt that was functionally invisible. This small change makes it visible and improves user feedback in multi-line expressions.Implementation Notes
This is a small change in
libcmd/repl-interacter.cc:This makes no functional changes to how the REPL parses or evaluates input. It purely affects the string shown to the user when continuing a multi-line expression.
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.