Fix: QueryPathInfo throws on invalid path error in daemon#15134
Merged
Conversation
xokdvium
approved these changes
Feb 3, 2026
Contributor
|
LGTM. On a separate note, I think the current approach where some stores return a nullptr and swallow the exception or allow the exception to escape is really bad (evidently). Would be nicer to consistently return nullptr instead. |
|
Successfully created backport PR for |
This was referenced Feb 3, 2026
|
Successfully created backport PR for |
lovesegfault
added a commit
to lovesegfault/rio-build
that referenced
this pull request
Feb 24, 2026
Pin nix to 2.33.3 to avoid the QueryPathInfo regression in 2.32-2.33.2 (NixOS/nix#15134) where not-found paths send STDERR_ERROR instead of STDERR_LAST + u64(0). Also fix read_stderr_loop to treat STDERR_ERROR as a terminal message — previously it parsed the error payload but continued looping for the next STDERR message, hanging forever when the daemon had already moved on to waiting for the next opcode. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
LunNova
pushed a commit
to LunNova/rio-build
that referenced
this pull request
Mar 9, 2026
Pin nix to 2.33.3 to avoid the QueryPathInfo regression in 2.32-2.33.2 (NixOS/nix#15134) where not-found paths send STDERR_ERROR instead of STDERR_LAST + u64(0). Also fix read_stderr_loop to treat STDERR_ERROR as a terminal message — previously it parsed the error payload but continued looping for the next STDERR message, hanging forever when the daemon had already moved on to waiting for the next opcode.
brittonr
pushed a commit
to brittonr/nix
that referenced
this pull request
Apr 1, 2026
…aemon Fix: `QueryPathInfo` throws on invalid path error in daemon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
This fixes a small regression introduced by #13951 (specific diff), which occurs when calling
QueryPathInfoon an invalid path.Current (bad) behavior: When called on an invalid path
queryPathInfothrows an exception, resulting in the entire operation failing. This also implies theelseclause is currently unreachable.Corrected behavior: Catch
InvalidPathexceptions and return0on the connection.Context
Add 👍 to pull requests you find important.
The Nix maintainer team uses a GitHub project board to schedule and track reviews.