[Backport 2.15-maintenance] StorePath: reject names starting with '.', Fix typo in error message of too long store path#9130
Merged
roberth merged 2 commits intoOct 23, 2023
Conversation
(cherry picked from commit 303858a)
This has been the behaviour before Nix 2.4. It was dropped in a rewrite in 759947b, allowing the creation of store paths that aren't considered valid by older Nix versions or other Nix tooling. Nix 2.4 didn't ship in NixOS until 22.05, and stdenv.mkDerivation in nixpkgs drops leading periods since April 2022, so it's unlikely anyone is relying on the current lax behaviour. Closes NixOS#9091. Change-Id: I4a57bd9899e1b0dba56870ae5a1b680918a18ce9
a2215e7 to
a06801d
Compare
|
Backport failed for Please cherry-pick the changes locally. git fetch origin 2.13-maintenance
git worktree add -d .worktree/backport-9130-to-2.13-maintenance origin/2.13-maintenance
cd .worktree/backport-9130-to-2.13-maintenance
git checkout -b backport-9130-to-2.13-maintenance
ancref=$(git merge-base 765d19be6a29cfb2aacbcfe29831b9ee618b756c a06801de17fab47b68300c6736cd031fb0d25b6e)
git cherry-pick -x $ancref..a06801de17fab47b68300c6736cd031fb0d25b6e |
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Backport
Context
Priorities
Add 👍 to pull requests you find important.