Add missing --hash-algo flag to nix store add

[Ericson2314]

Motivation

This is a paramter to the underlying addToStore that we forgot to expose

Context

Was supposed to have been part of #8915.

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

[grahamc]

Maybe --algorithm to match the adjacent word flags, plus docs on what the options are? By the way it looks like —name and —mode above are both using -n as the short flag 😬

…

On Fri, Jan 19, 2024, at 1:19 AM, John Ericson wrote: Motivation This is a paramter to the underlying `addToStore` that we forgot to expose Context Was supposed to have been part of #8915 <#8915>. Priorities and Process Add 👍 to pull requests you find important <https://github.com/NixOS/nix/pulls?q=is%3Aopen+sort%3Areactions-%2B1-desc>. The Nix maintainer team uses a GitHub project board <https://github.com/orgs/NixOS/projects/19> to schedule and track reviews <https://github.com/NixOS/nix/tree/master/maintainers#project-board-protocol>. You can view, comment on, or merge this pull request online at: #9809 Commit Summary • f03b49c <f03b49c> Add missing `--algo` flag to `nix store add` File Changes (1 file <https://github.com/NixOS/nix/pull/9809/files>) • *M* src/nix/add-to-store.cc <https://github.com/NixOS/nix/pull/9809/files#diff-345e94108682437ad97f353613e507147c1dc66b4b123067ecf405173b29c0e1> (7) Patch Links: • https://github.com/NixOS/nix/pull/9809.patch • https://github.com/NixOS/nix/pull/9809.diff — Reply to this email directly, view it on GitHub <#9809>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAASXLHD5P6BOMAMBXI3VZDYPIGARAVCNFSM6AAAAABCBN3QKKVHI2DSMVQWIX3LMV43ASLTON2WKOZSGA4DSNRZGAZTEMQ>. You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[edolstra]

By the way it looks like —name and —mode above are both using -n as the short flag

That looks like a cut&paste mistake. --mode doesn't need a short flag.

[thufschmitt]

Thanks :)

EDIT: Didn't see @grahamc 's comment. --algorithm might be better indeed. It's an advanced-enough option that we can afford to be very explicit

[thufschmitt]

-n for --mode is definitely a copy-paste error, I'll fix that in another PR

[Ericson2314]

I copied the "algo" name from elsewhere nix hash. oops it didn't match. Don't care what it is as long as its consistent.

[thufschmitt]

Discussed during the Nix maintainers meeting today:

• @roberth --algorithm makes more sense in isolation, but --algo is more consistent with the rest
• --hash-algo is nicer than --algo and even more consistent
• Agreement

@Ericson2314 will do the change, then it's good to go

[nixos-discourse]

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/2024-01-19-nix-team-meeting-minutes-116/38837/1