Skip to content

Fix cycle detection in nix repl#9926

Merged
edolstra merged 1 commit into
NixOS:masterfrom
9999years:fix-cycle-detection-in-nix-repl
Feb 5, 2024
Merged

Fix cycle detection in nix repl#9926
edolstra merged 1 commit into
NixOS:masterfrom
9999years:fix-cycle-detection-in-nix-repl

Conversation

@9999years

Copy link
Copy Markdown
Contributor

Motivation

Closes #8672

When printing values, key repeated values on the attribute binding pointers, not the value pointers.

Priorities and Process

Add 👍 to pull requests you find important.

The Nix maintainer team uses a GitHub project board to schedule and track reviews.

@9999years 9999years requested a review from edolstra as a code owner February 4, 2024 04:38
@9999years 9999years force-pushed the fix-cycle-detection-in-nix-repl branch from 154c344 to 770d2bc Compare February 4, 2024 05:23
@github-actions github-actions Bot added the with-tests Issues related to testing. PRs with tests have some priority label Feb 4, 2024
@edolstra edolstra merged commit e190c20 into NixOS:master Feb 5, 2024
@9999years 9999years deleted the fix-cycle-detection-in-nix-repl branch February 5, 2024 17:46
tebowy pushed a commit to tebowy/nix that referenced this pull request Jul 11, 2024
…ix-repl

Fix cycle detection in `nix repl`

(cherry picked from commit e190c20)
Change-Id: Ie385e781b9f0b7171ca653bcd53a990bb41f9e4b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

with-tests Issues related to testing. PRs with tests have some priority

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

Cycle detection in nix repl output doesn't match nix-instantiate

2 participants