Make computeAlignment more efficient #389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `Test.Tasty.Ingredients.ConsoleReporter.computeAlignment` evaluation is extremely inefficient: firstly because `data Maximum` lacks strictness annotations, and secondly because `foldTestTree` operates not even over `Maximum a`, but over `Int -> Maximum a`. The patch improves efficiency of `computeAlignment` and arguably makes its implementation simpler.
VictorCMiraldo
approved these changes
Sep 17, 2023
Collaborator
VictorCMiraldo
left a comment
There was a problem hiding this comment.
LGTM! Thanks for the patch @Bodigrim
martijnbastiaan
approved these changes
Sep 17, 2023
Contributor
martijnbastiaan
left a comment
There was a problem hiding this comment.
Looks much simpler!
netbsd-srcmastr
pushed a commit
to NetBSD/pkgsrc
that referenced
this pull request
Jan 29, 2025
Version 1.5.3 -------------- _2025-01-05_ * Console reporter: disable line wrapping ([#433](UnkindPartition/tasty#433)). * Console reporter: force flushing of stdout after `showCursor` ([#436](UnkindPartition/tasty#436)). Version 1.5.2 -------------- _2024-11-03_ * Partially revert [#393](UnkindPartition/tasty#393) to fix progress reporting outside of Emacs. * Do not depend on `unbounded-delays` on `ppc64`, `s390x` and `riscv64` ([#371](UnkindPartition/tasty#371), [#422](UnkindPartition/tasty#422), [#423](UnkindPartition/tasty#423)). Version 1.5.1 -------------- _2024-06-22_ * Performance improvements ([#389](UnkindPartition/tasty#389), [#390](UnkindPartition/tasty#390)). * Progress reporting in Emacs: use `\r` instead of ANSI escape sequences ([#393](UnkindPartition/tasty#393)). * Console reporter: fix unintended change to `foldHeading` ([#396](UnkindPartition/tasty#396)). * Prune empty test subtrees from `TestTree` ([#403](UnkindPartition/tasty#403)). * Add `instance Eq Timeout` and `instance Ord Timeout` ([#415](UnkindPartition/tasty#415)). * Add ability to supply options for launchers and reporters at the top-level of test tree ([#417](UnkindPartition/tasty#417)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
Test.Tasty.Ingredients.ConsoleReporter.computeAlignmentevaluation is extremely inefficient: firstly becausedata Maximumlacks strictness annotations, and secondly becausefoldTestTreeoperates not even overMaximum a, but overInt -> Maximum a.The patch improves efficiency of
computeAlignmentand arguably makes its implementation simpler.CC @martijnbastiaan for review.