Skip to content

Commit 2681714

Browse files
committed
Improve logging for unknown args
1 parent 3551171 commit 2681714

File tree

1 file changed

+9
-1
lines changed

1 file changed

+9
-1
lines changed

src/llmtuner/extras/misc.py

Lines changed: 9 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -5,6 +5,9 @@
55
from typing import TYPE_CHECKING, Any, Dict, Optional, Tuple
66
from transformers import InfNanRemoveLogitsProcessor, LogitsProcessorList
77

8+
import logging
9+
logger = logging.getLogger(__name__)
10+
811
try:
912
from transformers.utils import (
1013
is_torch_bf16_cpu_available,
@@ -111,7 +114,12 @@ def parse_args(parser: "HfArgumentParser", args: Optional[Dict[str, Any]] = None
111114
elif len(sys.argv) == 2 and sys.argv[1].endswith(".json"):
112115
return parser.parse_json_file(os.path.abspath(sys.argv[1]))
113116
else:
114-
return parser.parse_args_into_dataclasses()
117+
(*parsed_args, unknown_args) = parser.parse_args_into_dataclasses(return_remaining_strings=True)
118+
if unknown_args:
119+
logger.warning(parser.format_help())
120+
logger.error(f'\nGot unknown args, potentially deprecated arguments: {unknown_args}\n')
121+
raise ValueError(f"Some specified arguments are not used by the HfArgumentParser: {unknown_args}")
122+
return (*parsed_args,)
115123

116124

117125
def torch_gc() -> None:

0 commit comments

Comments
 (0)