Skip to content

Commit 4d22bb0

Browse files
authored
Improve instructions for releasing Log4cxx (#433)
* Remove signature complexities * The release is now signed by ASF Logging Services RM * Simplify packaged artefact file name
1 parent 8fd7236 commit 4d22bb0

File tree

4 files changed

+10
-17
lines changed

4 files changed

+10
-17
lines changed

admin/release-review-instructions.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,10 +30,10 @@ Steps
3030
- Click the `>` to the left of `Run action/upload-artifact`
3131
- The numbered steps will display
3232
- Click the link next to `Artifact download URL:`
33-
- The browser will download the file `Upload release files.zip` onto your system
33+
- The browser will download the file `release_files.zip` onto your system
3434
1. Confirm the artifacts were sourced from Github using these commands
3535
- `mkdir /tmp/log4cxx-github`
3636
- `cd /tmp/log4cxx-github`
37-
- `unzip "$HOME/Downloads/Upload release files.zip"`
37+
- `unzip "$HOME/Downloads/release_files.zip"`
3838
- `diff /tmp/log4cxx{,-github}/apache-log4cxx-1.3.1.tar.gz.sha512`
3939
- `diff /tmp/log4cxx{,-github}/apache-log4cxx-1.3.1.zip.sha512`

admin/releasing.md

Lines changed: 4 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -12,13 +12,14 @@ Prerequisites
1212
* The web-site for the new version has been published to https://logging.staged.apache.org/log4cxx (using [this procedure](staging.md) )
1313
* An e-mail has been sent to [email protected] announcing the intention to release
1414
* Your e-mail client can send mail from your `@apache.org` address. (Refer: https://eventmesh.apache.org/community/how-to-use-email/)
15-
* Your public key is available in [Apache Logging KEYS file](https://dist.apache.org/repos/dist/release/logging/KEYS)
1615

1716
Steps
1817
-----
1918

2019
1. Tag HEAD as the release candidate
2120
- `git checkout master`
21+
- `git pull`
22+
- `git tag v1.3.1-RC1`
2223
- `git push origin tag v1.3.1-RC1`
2324
1. Remove the old artifacts from svn
2425
- `svn co https://dist.apache.org/repos/dist/dev/logging -N apache-dist-logging-dev`
@@ -38,12 +39,9 @@ Steps
3839
- Click the `>` to the left of `Run action/upload-artifact`
3940
- The numbered steps will display
4041
- Click the link next to `Artifact download URL:`
41-
- The browser will download the file `Upload release files.zip` onto your system
42+
- The browser will download the file `release_files.zip` onto your system
4243
1. Unpack the release files using these commands (with `apache-dist-logging-dev/log4cxx/1.3.1` as the working directory)
43-
- `unzip "$HOME/Downloads/Upload release files.zip"`
44-
1. Sign release artifacts (Refer: https://infra.apache.org/release-signing.html) (with `apache-dist-logging-dev/log4cxx/1.3.1` as the working directory)
45-
- `gpg --armor --output apache-log4cxx-1.3.1.zip.asc --detach-sig apache-log4cxx-1.3.1.zip`
46-
- `gpg --armor --output apache-log4cxx-1.3.1.tar.gz.asc --detach-sig apache-log4cxx-1.3.1.tar.gz`
44+
- `unzip "$HOME/Downloads/release_files.zip"`
4745
1. Send the new artifacts to svn (with `apache-dist-logging-dev/log4cxx/1.3.1` as the working directory)
4846
- `svn add *`
4947
- `svn commit -m 'log4cxx 1.3.1'`
@@ -60,9 +58,6 @@ Steps
6058
- `git checkout v1.3.1-RC1`
6159
- `git tag rel/v1.3.1`
6260
- `git push origin tag rel/v1.3.1`
63-
1. Set your details in `src/site/CMakeLists.txt`
64-
- Set your name in the LOG4CXX_RELEASE_MANAGER variable
65-
- Set your GnuPG key in the LOG4CXX_RELEASE_MANAGER_KEY variable
6661
1. Enter the release date in `src/site/markdown/change-report-gh.md`
6762
- Commit the change
6863
- Update the staged web site using [the update procedure](staging.md)

admin/staging.md

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,15 +45,13 @@ Steps to add a new version to the Log4cxx web site
4545
- `cd /tmp/log4cxx-site`
4646
- `git checkout asf-staging`
4747
1. Use the newly generated files for the web site documentation
48-
- `git rm -r 1.3.1`
4948
- `mv /tmp/build/src/site/html /tmp/log4cxx-site/1.3.1`
5049
- `git add 1.3.1`
5150
1. Update the symbolic links in the base of the web site working directory
5251
- `cd /tmp/log4cxx-site`
53-
- `rm latest_stable old_stable`
54-
- `ln -s 1.3.1 latest_stable`
52+
- `rm old_stable`
5553
- `ln -s 1.2.0 old_stable`
56-
- `git add latest_stable old_stable`
54+
- `git add old_stable`
5755
1. Update `.htaccess` so the final `RewriteRule` redirects to the new version
5856
- `RewriteRule ^(.*)$ /log4cxx/1.3.1/$1 [R=temp,L]`
5957
- `git add .htaccess`

src/site/CMakeLists.txt

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -24,8 +24,8 @@ set(LOG4CXX_SOURCE_MIRROR_URL "https://www.apache.org/dyn/closer.cgi/logging/log
2424
set(APACHE_LOGGING_DISTRIBUTION_URL "https://www.apache.org/dist/logging")
2525
set(LOG4CXX_DOCUMENTATION_URL "https://logging.apache.org/log4cxx")
2626
set(LOG4CXX_DISTRIBUTION_URL "${APACHE_LOGGING_DISTRIBUTION_URL}/log4cxx/${LOG4CXX_RELEASE_VERSION}/${LOG4CXX_SOURCE_PACKAGE_FILE_NAME}")
27-
set(LOG4CXX_RELEASE_MANAGER "Stephen Webb")
28-
set(LOG4CXX_RELEASE_MANAGER_KEY "C6FC425C96722EFC4E2D02D5D4305EBC16B4A78D")
27+
set(LOG4CXX_RELEASE_MANAGER "ASF Logging Services RM")
28+
set(LOG4CXX_RELEASE_MANAGER_KEY "077E8893A6DCC33DD4A4D5B256E73BA9A0B592D0")
2929

3030
configure_file( ${CMAKE_CURRENT_SOURCE_DIR}/doxy/Doxyfile.in
3131
${CMAKE_CURRENT_BINARY_DIR}/Doxyfile )

0 commit comments

Comments
 (0)