Skip to content

Commit d5d672c

Browse files
Krishna Paifacebook-github-bot
Krishna Pai
authored andcommitted
Disable wave aggregation tests to supress TestX warnings (facebookincubator#10605)
Summary: Pull Request resolved: facebookincubator#10605 TestX fails tests that are just skipped, It seems the only way to suppress this is to disable the tests. Eg: https://www.internalfb.com/intern/test/281475083337445?ref_report_id=0 Reviewed By: Yuhta Differential Revision: D60458657 fbshipit-source-id: fff408924d0db98486215300a5865c5191e77025
1 parent 5df73bc commit d5d672c

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

velox/experimental/wave/exec/tests/AggregationTest.cpp

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -59,7 +59,7 @@ class AggregationTest : public OperatorTestBase {
5959
void TearDown() override {}
6060
};
6161

62-
TEST_F(AggregationTest, singleKeySingleAggregate) {
62+
TEST_F(AggregationTest, DISABLED_singleKeySingleAggregate) {
6363
constexpr int kSize = 10;
6464
auto vector = makeRowVector({
6565
makeFlatVector<int64_t>(kSize, [](int i) { return i % 3; }),
@@ -76,7 +76,7 @@ TEST_F(AggregationTest, singleKeySingleAggregate) {
7676
AssertQueryBuilder(plan).assertResults(expected);
7777
}
7878

79-
TEST_F(AggregationTest, singleKeyMultiAggregate) {
79+
TEST_F(AggregationTest, DISABLED_singleKeyMultiAggregate) {
8080
constexpr int kSize = 10;
8181
auto vector = makeRowVector({
8282
makeFlatVector<int64_t>(kSize, [](int i) { return i % 3; }),
@@ -96,7 +96,7 @@ TEST_F(AggregationTest, singleKeyMultiAggregate) {
9696
AssertQueryBuilder(plan).assertResults(expected);
9797
}
9898

99-
TEST_F(AggregationTest, multiKeySingleAggregate) {
99+
TEST_F(AggregationTest, DISABLED_multiKeySingleAggregate) {
100100
constexpr int kSize = 10;
101101
// 0 1 0 1 0 1 0 1 0 1
102102
// 0 1 2 0 1 2 0 1 2 0
@@ -118,7 +118,7 @@ TEST_F(AggregationTest, multiKeySingleAggregate) {
118118
AssertQueryBuilder(plan).assertResults(expected);
119119
}
120120

121-
TEST_F(AggregationTest, tpchQ1) {
121+
TEST_F(AggregationTest, DISABLED_tpchQ1) {
122122
// TODO: Use StringView instead of int64_t for keys.
123123
struct {
124124
std::uniform_int_distribution<> returnflag{0, 2};

0 commit comments

Comments
 (0)