Skip to content

Console 3.2 Compat and use drupal/core for composer-highest.#2724

Merged
weitzman merged 2 commits into
masterfrom
symfony32
Apr 27, 2017
Merged

Console 3.2 Compat and use drupal/core for composer-highest.#2724
weitzman merged 2 commits into
masterfrom
symfony32

Conversation

@weitzman

Copy link
Copy Markdown
Member

No description provided.

@weitzman weitzman changed the title Use patched core for composer-highest. Console 3.2 Compat and use drupal/core for composer-highest. Apr 26, 2017
@weitzman weitzman mentioned this pull request Apr 26, 2017
@weitzman

Copy link
Copy Markdown
Member Author

Its green, and RTBC IMO. Any last thoughts? Ping @alexpott, @webflo @greg-1-anderson @catch56.

@webflo

webflo commented Apr 27, 2017

Copy link
Copy Markdown
Contributor

Awesome, i will open a follow-up to remove the dependency on webflo/drupal-core-8.4.x once the core patches is committed to 8.4.x.

Thanks!

@alexpott

alexpott commented May 2, 2017

Copy link
Copy Markdown
Contributor

This has caused https://www.drupal.org/node/2874827 which means that master can't install both 8.3.x and 8.4.x

Drush 8.x can't install 8.4.x atm which is probably okay as long as drush 9 has a release before 8.4.0.

@webflo

webflo commented May 2, 2017

Copy link
Copy Markdown
Contributor

@weitzman Its is feasible to backport the changes to drush 8?

@weitzman

weitzman commented May 2, 2017

Copy link
Copy Markdown
Member Author

I'm hesitant to try to get Drush 8 to work with Drupal 8.4. Many folks use Drush8 via the Phar and then the bundled Symfony classes will be 3.x while the project will be Symfony 3. This is a recipe for trouble.

How about we add conflict statements in the composer.json of Drush 8 and Drush 9 so folks are directed to the right Drush version?

Drush 9 will definitely have a release before 8.4.0

@alexpott

alexpott commented May 2, 2017

Copy link
Copy Markdown
Contributor

@weitzman so we just suck it up and say there is no Drush version that'll work with both 8.3.x and 8.4.x? That is going to be painful. At the moment 9.0.0-beta1 does work against both 8.3.x and 8.4.x.

Imo we should only be making this change once 8.4.0 is out.

@weitzman

weitzman commented May 2, 2017

Copy link
Copy Markdown
Member Author

Drush master should work with both Drupal 8.3 and 8.4 but you have to use a project-specific instance of Drush, not a global one. Blame the PHP community's Composer-fever if you dont like this. I'm just the messenger :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants