[FDC MCP] Merge multiple tools into dataconnect_info
#9056
Conversation
There was a problem hiding this comment.
Summary of Changes
Hello @fredzqm, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refactors the Firebase Data Connect tooling by consolidating multiple existing tools into a single, more powerful dataconnect_info utility. This change aims to provide a more cohesive and comprehensive way for users to inspect and understand their Data Connect configurations and deployed services, improving the overall developer experience.
Highlights
- Tool Consolidation: The pull request merges the functionalities of
get_connectors,get_schema, andlist_servicesinto a single, unified tool nameddataconnect_info. - New
dataconnect_infoTool: A new tool,dataconnect_info, has been introduced. This tool provides a comprehensive overview of Firebase Data Connect services, including details on local services fromfirebase.jsonand remote services from the Google Cloud Project, along with their associated schemas and connectors. - Codebase Simplification: The removal of three individual tool files (
get_connector.ts,get_schema.ts,list_services.ts) and the update toindex.tsstreamline the Data Connect toolset, reducing redundancy and simplifying maintenance.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request refactors several Data Connect tools (get_connectors, get_schema, list_services) into a single, more comprehensive dataconnect_info tool. This is a good simplification of the toolset.
My review focuses on the new dataconnect_info tool. I've identified a potential runtime error, a performance improvement opportunity by parallelizing API calls, and an inconsistency in output formatting. The suggested changes address these points to make the new tool more robust and efficient.
Merges the `dataconnect_list_services`, `dataconnect_get_connector`, and `dataconnect_get_schema` tools into a single `dataconnect_info` tool. This new tool provides a comprehensive view of all Data Connect services, schemas, and connectors, indicating whether they exist locally, remotely, or both. The output is formatted to prioritize information from the local workspace.
dataconnect_infodataconnect_status
dataconnect_statusdataconnect_info
| output.push(`You can find all of schema sources under ${schemaDir}/`); | ||
| if (s.deployed) { | ||
| output.push(`It's already deployed in the backend:\n`); | ||
| includeDeployedServiceInfo(s.deployed); |
There was a problem hiding this comment.
This may product empty output, as shown in your screenshot in the PR description
The
dataconnect_status