Skip to content

feat(storage): Add support for dual region gcs buckets #18862

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
bajajneha27 merged 6 commits into from
Jul 29, 2022
Merged

feat(storage): Add support for dual region gcs buckets #18862

bajajneha27 merged 6 commits into from
Jul 29, 2022

Conversation

@SandeepTuniki
Copy link
Contributor

@SandeepTuniki SandeepTuniki commented Jul 25, 2022

Addresses ##18329 and #18330

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jul 25, 2022
@SandeepTuniki SandeepTuniki added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 25, 2022
@SandeepTuniki SandeepTuniki added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2022
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 26, 2022
@SandeepTuniki SandeepTuniki marked this pull request as ready for review July 26, 2022 05:48
@SandeepTuniki SandeepTuniki requested review from a team as code owners July 26, 2022 05:48
@SandeepTuniki
Copy link
Contributor Author

SandeepTuniki commented Jul 26, 2022

The flaky failing test is unrelated to this PR, and is being tracked at #18854

dazuma
dazuma reviewed Jul 28, 2022
View reviewed changes
Copy link
Contributor

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like it's more than just docs:. There are functionality changes, a new Bucket#data_locations method, and a new custom_placement_config argument. Is that right?

bajajneha27
bajajneha27 reviewed Jul 28, 2022
View reviewed changes
Copy link
Contributor

@bajajneha27 bajajneha27 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM overall except for one minor comment.

@SandeepTuniki
Copy link
Contributor Author

SandeepTuniki commented Jul 28, 2022

This seems like it's more than just docs:. There are functionality changes, a new Bucket#data_locations method, and a new custom_placement_config argument. Is that right?

@dazuma Yes, I think this should be feat. I considered this similar to #17997. But this change would be part of GA, so feat is probably correct. @danielbankhead Can you confirm please?

@SandeepTuniki SandeepTuniki changed the title docs(storage): Document support for updated API of dual region buckets feat(storage): Document support for updated API of dual region buckets Jul 28, 2022
@SandeepTuniki SandeepTuniki changed the title feat(storage): Document support for updated API of dual region buckets feat(storage): Add support for dual region gcs buckets Jul 28, 2022
@danielbankhead
Copy link
Contributor

danielbankhead commented Jul 28, 2022

@SandeepTuniki yes, should be feat

@bajajneha27 bajajneha27 merged commit 674d9dd into main Jul 29, 2022
@bajajneha27 bajajneha27 deleted the storage-location-update branch July 29, 2022 06:22
@yoshi-code-bot yoshi-code-bot mentioned this pull request Jul 29, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bajajneha27 bajajneha27 bajajneha27 approved these changes

+1 more reviewer

@dazuma dazuma dazuma left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@SandeepTuniki @danielbankhead @dazuma @bajajneha27 @yoshi-kokoro