Skip to content

feat(storage): adding autoclass v2.1 features #23483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dazuma merged 15 commits into from
Nov 2, 2023
Merged

feat(storage): adding autoclass v2.1 features #23483

dazuma merged 15 commits into from
Nov 2, 2023
+92 −15

Conversation

@shivgautam
Copy link
Contributor

@shivgautam shivgautam commented Oct 27, 2023

fixes #23334

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Oct 27, 2023
@shivgautam shivgautam marked this pull request as ready for review October 27, 2023 14:10
@shivgautam
Copy link
Contributor Author

shivgautam commented Oct 27, 2023

The PR is ready for review. Acceptance & samples failure are unrelated to this change.

@shivgautam
Copy link
Contributor Author

shivgautam commented Oct 27, 2023 •
edited
Loading

These lines are commented out as they don't yet have tests.
https://github.com/googleapis/google-cloud-ruby/pull/23483/files#diff-1c445f12b16180bcbdde4cab77c9b5ca55acc3fff5a45c1dd7d2bb4abb64bf76R497-R503
I wasn't able to mock this one properly. Will work on it later.

Actual calls do work though.

@shivgautam
Copy link
Contributor Author

shivgautam commented Oct 31, 2023

These lines are commented out as they don't yet have tests. https://github.com/googleapis/google-cloud-ruby/pull/23483/files#diff-1c445f12b16180bcbdde4cab77c9b5ca55acc3fff5a45c1dd7d2bb4abb64bf76R497-R503 I wasn't able to mock this one properly. Will work on it later.

Added tests.

PR ready for review.

cojenco
cojenco reviewed Oct 31, 2023
View reviewed changes
Copy link

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@shivgautam Thanks for working on this! I have a few questions, and could mostly be me not fully understanding Ruby, so deferring to the Ruby experts for further review.

@shivgautam
feat(storage): code review changes.
f2caafa 
removed the function to update terminal storage class.
The generic method shall handle that call.
@shivgautam
feat(storage): sample update for autoclass using update_autoclass method
fdae77d
dazuma
dazuma approved these changes Nov 2, 2023
View reviewed changes
Copy link
Contributor

@dazuma dazuma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, besides some documentation formatting

dazuma
dazuma reviewed Nov 2, 2023
View reviewed changes
cojenco
cojenco approved these changes Nov 2, 2023
View reviewed changes
Copy link

@cojenco cojenco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks again for working on this!

@dazuma dazuma merged commit 9b45570 into main Nov 2, 2023
@dazuma dazuma deleted the sg-gcs-autoclass-v21 branch November 2, 2023 16:54
@cojenco
Copy link

cojenco commented Nov 2, 2023

Hi @dazuma could we cut a new release for this feature launch, thanks!

@yoshi-approver yoshi-approver added the release-please:force-run To run release-please label Nov 3, 2023
@release-please release-please bot removed the release-please:force-run To run release-please label Nov 3, 2023
@release-please release-please bot mentioned this pull request Sep 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cojenco cojenco cojenco approved these changes

+1 more reviewer

@dazuma dazuma dazuma approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Storage] Add support for Autoclass v2.1

4 participants

@shivgautam @cojenco @dazuma @yoshi-approver