Skip to content

feat(storage): support for object lock / retention #23732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
shivgautam merged 9 commits into from
Jan 9, 2024
Merged

feat(storage): support for object lock / retention #23732

shivgautam merged 9 commits into from
Jan 9, 2024

Conversation

@shivgautam
Copy link
Contributor

@shivgautam shivgautam commented Jan 5, 2024 •
edited
Loading

Fixes #23484

@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label Jan 5, 2024
@shivgautam shivgautam marked this pull request as ready for review January 5, 2024 09:43
@NivedhaSenthil NivedhaSenthil added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2024
@shivgautam shivgautam added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jan 8, 2024
SandeepTuniki
SandeepTuniki suggested changes Jan 8, 2024
View reviewed changes
SandeepTuniki
SandeepTuniki approved these changes Jan 9, 2024
View reviewed changes
Copy link
Contributor

@SandeepTuniki SandeepTuniki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@shivgautam shivgautam merged commit 9c625e3 into main Jan 9, 2024
@shivgautam shivgautam deleted the sg-gcs-object-lock branch January 9, 2024 06:36
@release-please release-please bot mentioned this pull request Jan 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dazuma dazuma Awaiting requested review from dazuma

@bajajneha27 bajajneha27 Awaiting requested review from bajajneha27

1 more reviewer

@SandeepTuniki SandeepTuniki SandeepTuniki approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: storage Issues related to the Cloud Storage API.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

storage: add support for object retention

4 participants

@shivgautam @SandeepTuniki @NivedhaSenthil @yoshi-kokoro