feat: expose row level serialization failures for JsonStreamWriter append #1686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dani29
reviewed
Jun 28, 2022
...oud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
dani29
reviewed
Jun 28, 2022
...bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/JsonStreamWriterTest.java
Show resolved
Hide resolved
gnanda
approved these changes
Jun 29, 2022
...oud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
...oud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/JsonStreamWriter.java
Outdated
Show resolved
Hide resolved
| currentRequestSize += protoMessage.getSerializedSize(); | ||
| } catch (IllegalArgumentException | ||
| | IllegalStateException | ||
| | NullPointerException exception) { |
Contributor
There was a problem hiding this comment.
Do we want to catch all of these? IllegalState is ambiguous, but NullPointerException seems like a more serious error indicating something is wrong, rather than a "row-level" error
Contributor
Author
There was a problem hiding this comment.
In JsonToProtoMessage#convertJsonToProtoMessage there are some Null and state checks, some of them are not relevant to a single line and some are, for example Preconditions.checkState(json.length() != 0, "JSONObject is empty."); is relevant for a single row and should be reported as such.
I'm not sure how we can even get to a point from JsonStreamWriter that we will have null values in JsonObjects, so I will remove the catch for null and state exceptions for now, and add them later if we see it's needed
google-cloud-bigquerystorage/src/main/java/com/google/cloud/bigquery/storage/v1/Exceptions.java
Outdated
Show resolved
Hide resolved
...bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/JsonStreamWriterTest.java
Show resolved
Hide resolved
...bigquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/JsonStreamWriterTest.java
Show resolved
Hide resolved
gnanda
approved these changes
Jun 30, 2022
steffnay
approved these changes
Jul 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.