Skip to content

fix: bug fix for streamWriter & jsonStreamWriter #2122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
GaoleMeng merged 14 commits into from
May 25, 2023
Merged

fix: bug fix for streamWriter & jsonStreamWriter #2122

GaoleMeng merged 14 commits into from
May 25, 2023

Conversation

@GaoleMeng
Copy link
Contributor

@GaoleMeng GaoleMeng commented May 25, 2023 •
edited
Loading

  1. When the user explicitly provides a table schema to JsonStreamWriter, whenever there is a schema update, we will overwrite the user provided table schema with the updated schema. And we will use this schema to set writer_schema. This will make the frontend not able to set default value, because default value is only set when the columns are not specified in the writer_schema.
  2. Also we combined another fix for location string for multiplexing comparision, we shouldn't use '==' to compare

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

GaoleMeng and others added 13 commits March 30, 2023 10:52
@GaoleMeng
feat: add public api to stream writer to set the maximum wait time
1726c85
@GaoleMeng
Merge branch 'googleapis:main' into main
9b9e420
@gcf-owl-bot @GaoleMeng
🦉 Updates from OwlBot post-processor
3f0c5eb 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@GaoleMeng
modify back the readme change from owl post processor
a448c8b
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
b15b140 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@GaoleMeng
Merge branch 'googleapis:main' into main
4f5c0ad
@GaoleMeng
Merge branch 'googleapis:main' into main
aa6d9c6
@GaoleMeng
Merge branch 'googleapis:main' into main
7055043
@GaoleMeng
Merge branch 'googleapis:main' into main
ea2e8fb
@GaoleMeng
fix: Reduce the timeout to 5 minutes for the requests wait time in qu…
affa11a 
…eue.

Since in write api server side we have total timeout of 2 minutes, it
does not make sense to wait 15 minutes to determine whether we have met
dead connection, let's reduce the timeout here
@gcf-owl-bot
🦉 Updates from OwlBot post-processor
60869f7 
See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md
@GaoleMeng
Merge branch 'googleapis:main' into main
fc565e0
@GaoleMeng
Merge branch 'googleapis:main' into main
e86b484
@GaoleMeng GaoleMeng requested a review from a team as a code owner May 25, 2023 00:37
@GaoleMeng GaoleMeng requested a review from chalmerlowe May 25, 2023 00:37
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. labels May 25, 2023
@GaoleMeng GaoleMeng requested a review from yirutang May 25, 2023 00:37
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label May 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 25, 2023
@yirutang yirutang added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 25, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 25, 2023
@GaoleMeng GaoleMeng changed the title fix: disable refresh writer when schema is explicitly given fix: bug fix for streamWriter & jsonStreamWriter May 25, 2023
@yirutang yirutang added the owlbot:run Add this label to trigger the Owlbot post processor. label May 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 25, 2023
@yirutang yirutang added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels May 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 25, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label May 25, 2023
@yirutang yirutang added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 25, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 25, 2023
@GaoleMeng GaoleMeng added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels May 25, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 25, 2023
@yirutang yirutang added the kokoro:run Add this label to force Kokoro to re-run the tests. label May 25, 2023
@GaoleMeng GaoleMeng added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 25, 2023
@yoshi-kokoro yoshi-kokoro removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels May 25, 2023
@GaoleMeng
fix: 1.disable refresh of stream writer when the table schema is
687ef3a 
explicitly provided 2. fix location string matching for multiplexing
@GaoleMeng GaoleMeng added the owlbot:run Add this label to trigger the Owlbot post processor. label May 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 25, 2023
@GaoleMeng GaoleMeng added the owlbot:run Add this label to trigger the Owlbot post processor. label May 25, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 25, 2023
@GaoleMeng GaoleMeng merged commit 36964a3 into googleapis:main May 25, 2023
@release-please release-please bot mentioned this pull request May 25, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request May 25, 2023
@release-please
chore(main): release 2.37.1 (#2123)
024e849 
🤖 I have created a release *beep* *boop*
---


## [2.37.1](https://togithub.com/googleapis/java-bigquerystorage/compare/v2.37.0...v2.37.1) (2023-05-25)


### Bug Fixes

* Bug fix for streamWriter & jsonStreamWriter ([#2122](https://togithub.com/googleapis/java-bigquerystorage/issues/2122)) ([36964a3](https://togithub.com/googleapis/java-bigquerystorage/commit/36964a39e0f2a7ede8c55c43313a32922c06fe15))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yirutang yirutang yirutang approved these changes

@chalmerlowe chalmerlowe Awaiting requested review from chalmerlowe chalmerlowe is a code owner automatically assigned from googleapis/api-bigquery

Assignees

No one assigned

Labels

api: bigquerystorage Issues related to the googleapis/java-bigquerystorage API. size: m Pull request size is medium.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@GaoleMeng @yirutang @yoshi-kokoro