feat: add ability to write Range values with JSONStreamWriter #2498
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
/gcbrun |
1 similar comment
Contributor
Author
|
/gcbrun |
yirutang
reviewed
May 16, 2024
| ServerStream<ReadRowsResponse> stream = client.readRowsCallable().call(readRowsRequest); | ||
| for (ReadRowsResponse response : stream) { | ||
| Preconditions.checkState(response.hasArrowRecordBatch()); | ||
| rowCount += response.getRowCount(); |
Contributor
Author
There was a problem hiding this comment.
Added validation.
|
|
||
| JSONObject row3 = new JSONObject(); | ||
| JSONObject rangeDate3 = new JSONObject(); | ||
| rangeDate3.put("start", 18262); |
Contributor
Author
There was a problem hiding this comment.
Updated to use string values.
...gquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/JsonToProtoMessageTest.java
Show resolved
Hide resolved
yirutang
reviewed
May 16, 2024
...gquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/JsonToProtoMessageTest.java
Show resolved
Hide resolved
…eJSONStreamWriter
…eJSONStreamWriter
Contributor
Author
|
/gcbrun |
PhongChuong
commented
May 31, 2024
Contributor
Author
PhongChuong
left a comment
There was a problem hiding this comment.
@yirutang
Thanks for the review. I've updated the PR with the suggestions. PTAL.
...gquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/JsonToProtoMessageTest.java
Show resolved
Hide resolved
|
|
||
| JSONObject row3 = new JSONObject(); | ||
| JSONObject rangeDate3 = new JSONObject(); | ||
| rangeDate3.put("start", 18262); |
Contributor
Author
There was a problem hiding this comment.
Updated to use string values.
| ServerStream<ReadRowsResponse> stream = client.readRowsCallable().call(readRowsRequest); | ||
| for (ReadRowsResponse response : stream) { | ||
| Preconditions.checkState(response.hasArrowRecordBatch()); | ||
| rowCount += response.getRowCount(); |
Contributor
Author
There was a problem hiding this comment.
Added validation.
Contributor
Author
|
/gcbrun |
yirutang
reviewed
May 31, 2024
...gquerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/JsonToProtoMessageTest.java
Show resolved
Hide resolved
...uerystorage/src/test/java/com/google/cloud/bigquery/storage/v1/it/ITBigQueryStorageTest.java
Outdated
Show resolved
Hide resolved
yirutang
approved these changes
May 31, 2024
Contributor
Author
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2481 ☕️