feat: adding preserveAsciiControlCharacter to CSVOptions (#1491)

* adding ASCII support for external config

* adding tests for preserveAscii...

* adding tests for preserveAscii...

* changing 'False' to False

* linting

Author: nayaknishant

google/cloud/bigquery/external_config.py

@@ -418,6 +418,20 @@ def encoding(self):
     def encoding(self, value):
         self._properties["encoding"] = value
 
+    @property
+    def preserve_ascii_control_characters(self):
+        """bool: Indicates if the embedded ASCII control characters
+        (the first 32 characters in the ASCII-table, from '\x00' to '\x1F') are preserved.
+
+        See
+        https://cloud.google.com/bigquery/docs/reference/rest/v2/tables#CsvOptions.FIELDS.preserve_ascii_control_characters
+        """
+        return self._properties.get("preserveAsciiControlCharacters")
+
+    @preserve_ascii_control_characters.setter
+    def preserve_ascii_control_characters(self, value):
+        self._properties["preserveAsciiControlCharacters"] = value
+
     @property
     def field_delimiter(self):
         """str: The separator for fields in a CSV file. Defaults to comma (',').

tests/unit/test_external_config.py

@@ -248,6 +248,7 @@ def test_from_api_repr_csv(self):
                     "allowQuotedNewlines": True,
                     "allowJaggedRows": False,
                     "encoding": "encoding",
+                    "preserveAsciiControlCharacters": False,
                 },
             },
         )
@@ -263,6 +264,7 @@ def test_from_api_repr_csv(self):
         self.assertEqual(ec.options.allow_quoted_newlines, True)
         self.assertEqual(ec.options.allow_jagged_rows, False)
         self.assertEqual(ec.options.encoding, "encoding")
+        self.assertEqual(ec.options.preserve_ascii_control_characters, False)
 
         got_resource = ec.to_api_repr()
 
@@ -283,6 +285,7 @@ def test_to_api_repr_csv(self):
         options.quote_character = "quote"
         options.skip_leading_rows = 123
         options.allow_jagged_rows = False
+        options.preserve_ascii_control_characters = False
         ec.csv_options = options
 
         exp_resource = {
@@ -294,6 +297,7 @@ def test_to_api_repr_csv(self):
                 "allowQuotedNewlines": True,
                 "allowJaggedRows": False,
                 "encoding": "encoding",
+                "preserveAsciiControlCharacters": False,
             },
         }
 
@@ -514,17 +518,23 @@ def test_csv_options_getter_and_setter(self):
         from google.cloud.bigquery.external_config import CSVOptions
 
         options = CSVOptions.from_api_repr(
-            {"allowJaggedRows": True, "allowQuotedNewlines": False}
+            {
+                "allowJaggedRows": True,
+                "allowQuotedNewlines": False,
+                "preserveAsciiControlCharacters": False,
+            }
         )
         ec = external_config.ExternalConfig(external_config.ExternalSourceFormat.CSV)
 
         self.assertIsNone(ec.csv_options.allow_jagged_rows)
         self.assertIsNone(ec.csv_options.allow_quoted_newlines)
+        self.assertIsNone(ec.csv_options.preserve_ascii_control_characters)
 
         ec.csv_options = options
 
         self.assertTrue(ec.csv_options.allow_jagged_rows)
         self.assertFalse(ec.csv_options.allow_quoted_newlines)
+        self.assertFalse(ec.csv_options.preserve_ascii_control_characters)
         self.assertIs(ec.options._properties, ec._properties[CSVOptions._RESOURCE_NAME])
         self.assertIs(
             ec.csv_options._properties, ec._properties[CSVOptions._RESOURCE_NAME]
@@ -848,6 +858,7 @@ def test_to_api_repr(self):
         options.allow_quoted_newlines = True
         options.allow_jagged_rows = False
         options.encoding = "UTF-8"
+        options.preserve_ascii_control_characters = False
 
         resource = options.to_api_repr()
 
@@ -860,6 +871,7 @@ def test_to_api_repr(self):
                 "allowQuotedNewlines": True,
                 "allowJaggedRows": False,
                 "encoding": "UTF-8",
+                "preserveAsciiControlCharacters": False,
             },
         )