gulp/gulp.cli is exits with code 0 if managed to start

[floatdrop]

I can not find where gulp handles error state of tasks. in this line in gulp and this line in gulp.cli (plus this) I cannot find where handler function appends to tasks.

[robrich]

Nice solution. At one time it was next to this section when it used to be in gulp.js and looked something like this:

gulp.on('err', function(e){
  var msg = formatError(e);
  gutil.log('Build failed: ', gutil.colors.red(msg));
  process.exit(1);
});

[floatdrop]

This is little nicer.

[yocontra]

@floatdrop Can't you just drop a process.exit(1) in https://github.com/gulpjs/gulp/blob/master/bin/gulp.js#L137

[floatdrop]

@contra that will exist on first failed task - what expected is exit after all tasks got a chance to run.

[yocontra]

@floatdrop Ah. Is there any room to handle these errors gracefully and not exit with code 1?

[floatdrop]

@contra this is what expect from us to do. This will signal automated build systems like travis or jenkins - that something wrong (i got about 20 build with success, before noticed that bug).

[yocontra]

@floatdrop Yeah but I'm asking - is there a way for us to let the user gracefully handle the errors to prevent this behavior?

[floatdrop]

@contra this isn't a user field of responsability, if this handler got error. This means, that all error handlers in tasks was either skipped or not binded to emitters (or try/catch was not placed) - so no, there's no way (imo).

[yocontra]

@floatdrop I see what you're saying - they should just handle it inside the task thats failing. Seems good to me!

[robrich]

Orchestrator listens to the stream's on('err' so the stream believes it's handled. Should Orchestrator throw if the orchestration ends in an error and there's no callback?