Introduce verificationSuccessful boolean

Flowdalic · Flowdalic · commit 2ceadc0de106 · 2019-05-16T16:51:31.000+02:00
diff --git a/smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XMPPTCPConnection.java b/smack-tcp/src/main/java/org/jivesoftware/smack/tcp/XMPPTCPConnection.java
@@ -879,7 +879,11 @@ else if (keyStoreType != null) {
                 verifierHostname = getXMPPServiceDomain().toString();
             }
         }
-        if (!verifier.verify(verifierHostname, sslSocket.getSession())) {
+
+        final boolean verificationSuccessful;
+        // Verify the TLS session.
+        verificationSuccessful = verifier.verify(verifierHostname, sslSocket.getSession());
+        if (!verificationSuccessful) {
             throw new CertificateException(
                             "Hostname verification of certificate failed. Certificate does not authenticate "
                                             + getXMPPServiceDomain());

Original file line number	Diff line number	Diff line change
`@@ -879,7 +879,11 @@ else if (keyStoreType != null) {`
`879`	`879`	`verifierHostname = getXMPPServiceDomain().toString();`
`880`	`880`	`}`
`881`	`881`	`}`
`882`		`- if (!verifier.verify(verifierHostname, sslSocket.getSession())) {`
	`882`	`+`
	`883`	`+ final boolean verificationSuccessful;`
	`884`	`+ // Verify the TLS session.`
	`885`	`+ verificationSuccessful = verifier.verify(verifierHostname, sslSocket.getSession());`
	`886`	`+ if (!verificationSuccessful) {`
`883`	`887`	`throw new CertificateException(`
`884`	`888`	`"Hostname verification of certificate failed. Certificate does not authenticate "`
`885`	`889`	`+ getXMPPServiceDomain());`