Skip to content

Fixed some hyperlink+spacing related issues #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Aug 5, 2020
Merged

Fixed some hyperlink+spacing related issues #31

merged 3 commits into from
Aug 5, 2020
+15 −15

Conversation

jarp0l
Copy link
Contributor

@jarp0l jarp0l commented Aug 3, 2020

Fixed some hyperlink issues related to formatting plus a few spacing related issues.

@jarp0l
Fixed some hyperlink+spacing issues

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
726fd3a 
Fixed some hyperlink issues related to formatting plus a few spacing related issues.
@CLAassistant
Copy link

CLAassistant commented Aug 3, 2020 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

jarp0l added 2 commits August 3, 2020 18:02
@jarp0l
Fixed a hyperlink issue

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
123a65b
@jarp0l
Fixed hyperlink issues

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
1ba11bd
@jarp0l jarp0l changed the title Fixed some hyperlink+spacing issues Fixed some hyperlink+spacing related issues Aug 3, 2020
@theBstar
Copy link
Member

theBstar commented Aug 5, 2020

Thanks for taking the time to raise a PR. I will have a look by EOD.

@theBstar theBstar self-requested a review August 5, 2020 02:51
theBstar
theBstar approved these changes Aug 5, 2020
View reviewed changes
Copy link
Member

@theBstar theBstar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. This looks good. I am merging this now. 🎉

@theBstar theBstar merged commit 88cd100 into javascript-tutorial:master Aug 5, 2020
@jarp0l
Copy link
Contributor Author

jarp0l commented Aug 6, 2020

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@theBstar theBstar

Assignees
No one assigned
Labels
needs +1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jarp0l @CLAassistant @theBstar @javascript-translate-bot