Use IntelliJ IDE PasswordSafe to store credentials #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yahavi
suggested changes
Feb 18, 2020
src/main/java/com/jfrog/ide/idea/configuration/GlobalSettings.java
Outdated
Show resolved
Hide resolved
src/main/java/com/jfrog/ide/idea/configuration/XrayServerConfigImpl.java
Outdated
Show resolved
Hide resolved
|
|
||
| public void updateConfig(XrayServerConfigImpl xrayConfig) { | ||
| if (this.xrayConfig.getUrl() != null && !this.xrayConfig.getUrl().equals(xrayConfig.getUrl())) { | ||
| this.xrayConfig.removeCredentialsFromPasswordSafe(); |
There was a problem hiding this comment.
At first glance, it looks like updateConfig removes the credentials from the passwordSafe and set them again. Are you sure the deletion is necessary?
There was a problem hiding this comment.
IMO it is necessary.
If a certain URL was previously saved to the password safe, and then the URL changes -> I think we should remove the old one.
src/main/java/com/jfrog/ide/idea/configuration/GlobalSettings.java
Outdated
Show resolved
Hide resolved
|
I was using an incorrect API for creating the CredentialsAttributes object. |
9b276d4 to
e5300da
Compare
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.