JDL script still allows for generation when entity namings are ambiguous

[kevintanhongann]

JDL script still allows for generation when entity namings are ambiguous. This should not happen for namings that resembles reserved words in Java.

For example:

entity List {
}

[kevintanhongann]

Suggestion on how to resolve the issue:

lib/jdl/converters/validators/entity-validator.ts

validate(jdlEntity, options: ValidatorOptions = {}) {
    super.validate(jdlEntity);
    if (options.checkReservedKeywords) {
      checkForReservedClassName(jdlEntity);
    }
  }

into just

validate(jdlEntity, options: ValidatorOptions = {}) {
    super.validate(jdlEntity);
    checkForReservedClassName(jdlEntity);
  }

@mshima lemme know your thoughts. And lemme know if I should push this change.

[mshima]

@kevintanhongann thanks for analyzing the issue.
We are moving validation alway from jdl and pushing to related generators.

Java validation should happen in java/bootstrap.

generator-jhipster/generators/java/generators/bootstrap/generator.ts

Line 69 in 1759345

const reservedKeywork = packageName!.split('.').find(isReservedJavaKeyword);

We should add a configuringEachEntity priority and check there.

[mshima]

@kevintanhongann can you contribute with a Pr?

[kevintanhongann]

@mshima will inspect the problem a bit further and contribute a PR.