Skip to content

Commit 4429284

Browse files
feat!: Reduce wait default timeout from 15 minutes to 10 seconds (#211)
## Description: For command, 15 minute timeout was picked with the Ethereum module in mind, but for most applications this seems excessive. This PR reduces the waiting time from 15 minutes to 10 seconds, that seems to be a reasonable timeout across requests and execs. ## Is this change user facing? <!-- A user facing change is one that you should expect a day-to-day user to encounter or if the change requires user-action upon or before upgrading. If in doubt, select "Yes" --> * [X] Yes * [ ] No <!-- If yes, please add the label to this Pull Request --> ## References (if applicable): <!-- Add relevant Github Issues, Discord threads, or other helpful information. --> Closes #173
1 parent b7991dc commit 4429284

File tree

2 files changed

+2
-2
lines changed

2 files changed

+2
-2
lines changed

core/server/api_container/server/startosis_engine/kurtosis_instruction/wait/wait.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -33,7 +33,7 @@ const (
3333
TimeoutArgName = "timeout"
3434

3535
defaultInterval = 1 * time.Second
36-
defaultTimeout = 15 * time.Minute
36+
defaultTimeout = 10 * time.Second
3737
)
3838

3939
func NewWait(serviceNetwork service_network.ServiceNetwork, runtimeValueStore *runtime_value_store.RuntimeValueStore) *kurtosis_plan_instruction.KurtosisPlanInstruction {

docs/docs/reference/starlark-instructions.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -589,7 +589,7 @@ response = plan.wait(
589589

590590
# The timeout value is the maximum time that the command waits for the assertion to be true
591591
# Follows Go "time.Duration" format https://pkg.go.dev/time#ParseDuration
592-
# OPTIONAL (Default: "15m")
592+
# OPTIONAL (Default: "10s")
593593
timeout = "5m",
594594

595595
# A Service name designating a service that already exists inside the enclave

0 commit comments

Comments
 (0)