Skip to content

Commit e63fd88

Browse files
authored
fix: remove historical enclave names from auto complete (#1059)
## Description: We used to populate historical enclave names and service names in auto complete but that was confusing to me and Barnabas.
1 parent 069ccfd commit e63fd88

File tree

1 file changed

+4
-5
lines changed
  • cli/cli/commands/service/logs

1 file changed

+4
-5
lines changed

cli/cli/commands/service/logs/logs.go

Lines changed: 4 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -105,17 +105,16 @@ var ServiceLogsCmd = &engine_consuming_kurtosis_command.EngineConsumingKurtosisC
105105
Args: []*args.ArgConfig{
106106
//TODO disabling enclaveID validation and serviceUUID validation for allowing consuming logs from removed or stopped enclaves
107107
//TODO we should enable them when #879 is ready: https://github.com/kurtosis-tech/kurtosis/issues/879
108-
enclave_id_arg.NewHistoricalEnclaveIdentifiersArgWithValidationDisabled(
108+
enclave_id_arg.NewEnclaveIdentifierArg(
109109
enclaveIdentifierArgKey,
110+
engineClientCtxKey,
110111
isEnclaveIdArgOptional,
111112
isEnclaveIdArgGreedy,
112113
),
113-
// TODO use the `NewServiceIdentifierArg` instead when we start storing identifiers in DB
114-
// TODO we should fix this after https://github.com/kurtosis-tech/kurtosis/issues/879
115-
service_identifier_arg.NewHistoricalServiceIdentifierArgWithValidationDisabled(
114+
service_identifier_arg.NewServiceIdentifierArg(
116115
serviceIdentifierArgKey,
117-
isServiceIdentifierArgOptional,
118116
isServiceIdentifierArgGreedy,
117+
isServiceIdentifierArgOptional,
119118
),
120119
},
121120
RunFunc: run,

0 commit comments

Comments
 (0)